From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64957C77B7A for ; Tue, 30 May 2023 09:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbjE3J1X (ORCPT ); Tue, 30 May 2023 05:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbjE3J1C (ORCPT ); Tue, 30 May 2023 05:27:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B8111D for ; Tue, 30 May 2023 02:25:59 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id A9F1066059A8; Tue, 30 May 2023 10:25:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685438758; bh=KG2FKmtvB1+MNxod1QWQZiu9EnjhpMcneY/1oVshCL0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HVSgHlMbOPveawPIlUjfDLvRl/f6CnezYmLOWuppi/VfXQ2PGeF/vQu57v+UlxZmL IhKvQKkv+tBT0sQzvA5M7QqDHjT8yPQPBr/muBNhavEEqnlxRrKqGlGQ0qTH3MHIMo aw+6xVDefmIxvt2WN8N7mY99Y0NM0lJf5d4MVEMKgkTvY1PTILV0aYwrR0as5PSTdh 1qNuQ3AREzKEInAbkoKVb/kDvyoxdd3js5sqXVKReq9x6VL8QTyhRST8dMGWaLPV4I mC1h9nivHS0g8FGP98id3CFHTVwNQDpMNjsTXW9ROV2PZg55GFHhC7HIRf5B7sz0Ad jHWQehUIOrp2Q== Message-ID: <68f7d44b-1c89-c452-1585-03b1d209597f@collabora.com> Date: Tue, 30 May 2023 11:25:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/3] spi: mt65xx: Properly handle failures in .remove() Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Mark Brown , Matthias Brugger Cc: linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> <20230530081648.2199419-2-u.kleine-koenig@pengutronix.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230530081648.2199419-2-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Il 30/05/23 10:16, Uwe Kleine-König ha scritto: > Returning an error code in a platform driver's remove function is wrong > most of the time and there is an effort to make the callback return > void. To prepare this rework the function not to exit early. > > There wasn't a real problem because if pm runtime resume failed the only > step missing was pm_runtime_disable() which isn't an issue. > > Signed-off-by: Uwe Kleine-König Reviewed-by: AngeloGioacchino Del Regno Cheers! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B35B7C7EE23 for ; Tue, 30 May 2023 09:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pO4sSFzZiSjZLLSac/c9i/iFWbxRkBGCJ9ymaxzb12E=; b=xInmwqHA4AgNJj 9V2JaT3SiN4r0UL3Z17uYFzApx603cxxrd5Z8QqpUicP+3TMYC3ab3dv+vEPsUMC55dbJ1TOgdMHj smI2dSaPqKcDjw2yhLqSMIjJIGTz4ue913Ybl8A4126nidbBwxmCWXFhzrxZSGjb4FlsfGSRUrHhx dHS5VfmGgrgq6JCOAZAeU42qZi7/bqbqKSWqbW2Gz0AvHT9MNpMgRvkGKIeyIAmImaCFFNSAsjAIn WYtzrw+Xwdeb/EfAtXbF9PQUQkIh+htILqL+OWiNxhcfbviOeg8vBtN37Mog4jzCCtoGD+6i7d4D7 C6VVlcFTGcjDwcKexVLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3vcA-00D9d4-1I; Tue, 30 May 2023 09:26:02 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3vc7-00D9bp-39; Tue, 30 May 2023 09:26:01 +0000 Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id A9F1066059A8; Tue, 30 May 2023 10:25:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685438758; bh=KG2FKmtvB1+MNxod1QWQZiu9EnjhpMcneY/1oVshCL0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HVSgHlMbOPveawPIlUjfDLvRl/f6CnezYmLOWuppi/VfXQ2PGeF/vQu57v+UlxZmL IhKvQKkv+tBT0sQzvA5M7QqDHjT8yPQPBr/muBNhavEEqnlxRrKqGlGQ0qTH3MHIMo aw+6xVDefmIxvt2WN8N7mY99Y0NM0lJf5d4MVEMKgkTvY1PTILV0aYwrR0as5PSTdh 1qNuQ3AREzKEInAbkoKVb/kDvyoxdd3js5sqXVKReq9x6VL8QTyhRST8dMGWaLPV4I mC1h9nivHS0g8FGP98id3CFHTVwNQDpMNjsTXW9ROV2PZg55GFHhC7HIRf5B7sz0Ad jHWQehUIOrp2Q== Message-ID: <68f7d44b-1c89-c452-1585-03b1d209597f@collabora.com> Date: Tue, 30 May 2023 11:25:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/3] spi: mt65xx: Properly handle failures in .remove() Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Mark Brown , Matthias Brugger Cc: linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20230530081648.2199419-1-u.kleine-koenig@pengutronix.de> <20230530081648.2199419-2-u.kleine-koenig@pengutronix.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230530081648.2199419-2-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_022600_138604_3957025E X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMzAvMDUvMjMgMTA6MTYsIFV3ZSBLbGVpbmUtS8O2bmlnIGhhIHNjcml0dG86Cj4gUmV0dXJu aW5nIGFuIGVycm9yIGNvZGUgaW4gYSBwbGF0Zm9ybSBkcml2ZXIncyByZW1vdmUgZnVuY3Rpb24g aXMgd3JvbmcKPiBtb3N0IG9mIHRoZSB0aW1lIGFuZCB0aGVyZSBpcyBhbiBlZmZvcnQgdG8gbWFr ZSB0aGUgY2FsbGJhY2sgcmV0dXJuCj4gdm9pZC4gVG8gcHJlcGFyZSB0aGlzIHJld29yayB0aGUg ZnVuY3Rpb24gbm90IHRvIGV4aXQgZWFybHkuCj4gCj4gVGhlcmUgd2Fzbid0IGEgcmVhbCBwcm9i bGVtIGJlY2F1c2UgaWYgcG0gcnVudGltZSByZXN1bWUgZmFpbGVkIHRoZSBvbmx5Cj4gc3RlcCBt aXNzaW5nIHdhcyBwbV9ydW50aW1lX2Rpc2FibGUoKSB3aGljaCBpc24ndCBhbiBpc3N1ZS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1 dHJvbml4LmRlPgoKUmV2aWV3ZWQtYnk6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdl bG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+CgpDaGVlcnMhCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==