From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA495C433EF for ; Fri, 22 Oct 2021 08:51:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 010D660FF2 for ; Fri, 22 Oct 2021 08:51:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 010D660FF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8B14083178; Fri, 22 Oct 2021 10:51:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634892670; bh=F8pq8Djqm2KxC43VigurFz8V86lDw0ehu+3GCjGcobw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BO93QjojCF8o2eo00mSVfIcKTh4FFUDlyAg7jcb8Luf0hYs3ytoXha0zw94kiVXeB R2KjlFP+D8FVhuC/ZRalkVn0C0PGsSZhpSRrY7n9svidVTTiQx5KiFP4Iu8hD8vrq5 zcVQjRvB/cSQVYnfxF66HXXHHIzznIZYZzohUsG+3eXF8UVB60z9oXrS2JWWQwC1uR iuOzlVn1yV0emSx06jyQrDq5JpQ6g/k1qZGgYdgBt7Y8iETubd0d0nmLbkmpN+KjIz UJTZfTcxYx2oi3I1ciQdIrzw4z78krMo67ct0nm2Jrp50o2aUymumgRn+rPmv/HsFe d2iY+5mNl8x2g== Received: by phobos.denx.de (Postfix, from userid 109) id D62AC83404; Fri, 22 Oct 2021 10:51:07 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4670882E48 for ; Fri, 22 Oct 2021 10:51:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4HbJ3W6QqMzQk98; Fri, 22 Oct 2021 10:51:03 +0200 (CEST) Subject: Re: [PATCH u-boot-marvell v3 00/39] kwboot higher baudrate To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20210924210716.29752-1-kabel@kernel.org> <20210930181419.ylymgidnzzifpz2x@pali> <4dc716e5-3d86-1b81-d761-08713a824f6d@denx.de> <20211001092856.gpagytudmfu45oht@pali> <20211001100904.n6njnf7bdfrqym2h@pali> <20211001123613.5ee89266@thinkpad> <71b0a466-c60e-94e5-7870-b755bb4e18f1@denx.de> <20211001124556.79bd6a18@thinkpad> <20211022084828.355oc7bqgm3spaay@pali> From: Stefan Roese Message-ID: <68ff4fdb-c6ef-2f6d-fbd3-ccd71d5b7f6e@denx.de> Date: Fri, 22 Oct 2021 10:50:59 +0200 MIME-Version: 1.0 In-Reply-To: <20211022084828.355oc7bqgm3spaay@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 92EA25AF X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On 22.10.21 10:48, Pali Rohár wrote: > On Friday 22 October 2021 10:38:16 Stefan Roese wrote: >> Hi Marek, Hi Pali, >> >> since now all is merged into master, I'm testing on my AXP target >> again. Please see below. >> >> On 01.10.21 12:45, Marek Behún wrote: >>> On Fri, 1 Oct 2021 12:40:29 +0200 >>> Stefan Roese wrote: >>> >>>> U-Boot SPL 2021.10-rc5-00431-g6c96332441cf-dirty (Oct 01 2021 - 12:38:55 >>>> +0200) >>>> High speed PHY - Version: 2.1.5 (COM-PHY-V20) >>>> High speed PHY - Ended Successfully >>>> DDR3 Training Sequence - Ver 5.7.4 >>>> DDR3 Training Sequence - Ended Successfully >>>> Trying to boot from BOOTROM >>>> Returning to BootROM (return address 0xffff0aa0)... >>>> rc=-1 errno=110 allow_non_xm=1 *non_xm_print=1 >>>> >>>> >>>> xmodem: Connection timed out >>> >>> No ACK from BootROM. It is possible that return_from_bootrom() was not >>> called, or failed, somehow in SPL. >> >> I'm not getting this when using master: >> >> [stefan@ryzen u-boot (master)]$ ./tools/kwboot -B 230400 -p -b >> u-boot-spl.kwb -t >> /dev/serial/by-id/usb-FTDI_FT232R_USB_UART_A1019EGY-if00-port0 >> Patching image boot signature to UART >> Injecting binary header code for changing baudrate to 230400 Bd >> Injecting code for changing baudrate back >> Aligning image header to Xmodem block size >> Sending boot message. Please reboot the target.../ >> Waiting 2s and flushing tty >> Sending boot image header (90496 bytes)... >> 0 % >> [......................................................................] >> 10 % >> [......................................................................] >> 19 % >> [......................................................................] >> 29 % >> [......................................................................] >> 39 % >> [......................................................................] >> 49 % >> [......................................................................] >> 59 % >> [......................................................................] >> 69 % >> [......................................................................] >> 79 % >> [......................................................................] >> 89 % >> [......................................................................] >> 99 % [....... ] >> Done >> >> U-Boot SPL 2021.10-00815-gf200a4bcecf1-dirty (Oct 22 2021 - 10:33:19 +0200) >> High speed PHY - Version: 2.1.5 (COM-PHY-V20) >> High speed PHY - Ended Successfully >> DDR3 Training Sequence - Ver 5.7.4 >> DDR3 Training Sequence - Ended Successfully >> Trying to boot from BOOTROM >> Returning to BootROM (return address 0xffff0aa0)... >> >> Changing baudrate to 230400 Bd >> Baudrate was not changed >> >> >> xmodem: Protocol error >> >> It works with the standard 115k. Any ideas why switching baudrate fails >> on AXP? > > When 115k baudrate is specified (or no baudrate is specified) then > kwboot does not inject any code for changing baudrate (as 115k is > default). So it looks like that issue is with switching. > > I have already some more "fixup" patches for kwboot and kwbimage, which > are fixing some issues which I found. So it is possible that you hit > some of that issue. I will pass patches to Marek and after some testing > we will send them to mailing list for review. Okay, sounds like a plan. I'll re-test after you (or Marek) sent these new patches. > I do not have any AXP board, so I cannot test or debug it manually. Unlucky but no big deal. I'll do the testing. Thanks, Stefan