From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61CCC04AB6 for ; Fri, 31 May 2019 10:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF85D26786 for ; Fri, 31 May 2019 10:28:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="YH+IXwzL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbfEaK2J (ORCPT ); Fri, 31 May 2019 06:28:09 -0400 Received: from mail.z3ntu.xyz ([128.199.32.197]:54130 "EHLO mail.z3ntu.xyz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfEaK2H (ORCPT ); Fri, 31 May 2019 06:28:07 -0400 Received: from g550jk.localnet (80-110-121-20.cgn.dynamic.surfer.at [80.110.121.20]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id A4A83C59F0; Fri, 31 May 2019 10:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1559298485; bh=Se4dUZTYep0OSyM0WeJ2pYjOSnGAVavK0huOC+bbDCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YH+IXwzLuOG3Z6tvsWcUim+3YLlZU9jcxO0xv+Y38t1ecU/TXC1hL1kwFL99yHXga hJoaRYID5kqhEUscXaNRwE0waJAd8xM3j0sFWwqz269g02BH6RRe4nenMKPUlGbOEG LYC0MdrlJTxZD8G0yw/6iRueY8ftowp/h4ovDw5o= From: Luca Weiss To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Fri, 31 May 2019 12:27:55 +0200 Message-ID: <6901794.oDhxEVzEqc@g550jk> In-Reply-To: <20190524092001.ztf3kntaj4uiswnv@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <4343071.IDWclfcoxo@g550jk> <20190524092001.ztf3kntaj4uiswnv@flea> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Weiss Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Fri, 31 May 2019 12:27:55 +0200 Message-ID: <6901794.oDhxEVzEqc@g550jk> References: <20190518170929.24789-1-luca@z3ntu.xyz> <4343071.IDWclfcoxo@g550jk> <20190524092001.ztf3kntaj4uiswnv@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190524092001.ztf3kntaj4uiswnv@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9DBC04AB6 for ; Fri, 31 May 2019 10:28:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D371926775 for ; Fri, 31 May 2019 10:28:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EqHa+mBG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="YH+IXwzL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D371926775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=z3ntu.xyz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74rtMI9MUwfnMoXuCaEpEi/C3uZJfSQqeTpA9CNNe5A=; b=EqHa+mBG8wOUWn 3sXo9x1/Qu2jlJslmUQkFJdBm6Yw9lx/dR5wG/DezWp2BJ0B/VNezq7Kl/lL4iPih5vfmf30L/VQE T5j7LAFO57oiHqxqUE854Bjxmxw+JCx0/iGa3FegW+5XSRULJ6pDPnECNRBVj5BUFYyudsqx9z6gg PZLBtlJiLbtf8zDaJEkZSkq+RbGKdxVEgc3Nh6swSw6okAilK8FhzW1Wru4QJvugcSSpYUFaqRhST 3bXXKxk5Oug3EBRe5jJuupuT0688d4vPxn4ZeCJTprFoyrjhWNPfyYTV+R0JSJDveCdmrsTUssJX+ jJz9SorKFdqvFr58G6yQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWeli-0003D4-Ei; Fri, 31 May 2019 10:28:14 +0000 Received: from mail.z3ntu.xyz ([128.199.32.197]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWelc-0003Bv-MA for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 10:28:12 +0000 Received: from g550jk.localnet (80-110-121-20.cgn.dynamic.surfer.at [80.110.121.20]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id A4A83C59F0; Fri, 31 May 2019 10:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1559298485; bh=Se4dUZTYep0OSyM0WeJ2pYjOSnGAVavK0huOC+bbDCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YH+IXwzLuOG3Z6tvsWcUim+3YLlZU9jcxO0xv+Y38t1ecU/TXC1hL1kwFL99yHXga hJoaRYID5kqhEUscXaNRwE0waJAd8xM3j0sFWwqz269g02BH6RRe4nenMKPUlGbOEG LYC0MdrlJTxZD8G0yw/6iRueY8ftowp/h4ovDw5o= From: Luca Weiss To: Maxime Ripard Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Fri, 31 May 2019 12:27:55 +0200 Message-ID: <6901794.oDhxEVzEqc@g550jk> In-Reply-To: <20190524092001.ztf3kntaj4uiswnv@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <4343071.IDWclfcoxo@g550jk> <20190524092001.ztf3kntaj4uiswnv@flea> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_032811_336837_03B5DF44 X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Chen-Yu Tsai , Rob Herring , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel