From: Gianfranco Costamagna <locutusofborg@debian.org>
To: "brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "nsmaldone@tierratelematics.com" <nsmaldone@tierratelematics.com>,
"Marco.Arlone@roj.com" <Marco.Arlone@roj.com>
Subject: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value
Date: Fri, 28 Oct 2016 16:15:48 +0000 (UTC) [thread overview]
Message-ID: <690669269.1124561.1477671348137@mail.yahoo.com> (raw)
In-Reply-To: <CACJOhtKej4EZ3ufGGUr=Rf1X=hufmKtPLQH3y4x0kK4nNg5U0w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
(resending from my debian.org mail address, to avoid spam filtering)
Hi Broadcom developers and linux wireless list.
We found a possible issue in the cfg80211 implementation of the regulatory domain rules:
.reg_rules = {
/* IEEE 802.11b/g, channels 1..11 */
REG_RULE(2412-10, 2472+10, 40, 6, 20, 0),
the referred channel 11 has/should have a frequency of 2462, not 2472 (corresponding to channel 13).
Is this a typo in the code or the above comment?
(I'm not sure why the override of reg.c is in place for 2.4 Ghz frequencies)
Can you please double check and in case apply the attached patch?
thanks,
--
Gianfranco Costamagna
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-broadcom-cfg80211-fix-regulatory-channel-frequency.patch --]
[-- Type: text/x-diff, Size: 1248 bytes --]
From dc2eaeba8cf3d992a18745cfef1b74bbfc11715b Mon Sep 17 00:00:00 2001
From: Arlone Marco <marco.arlone@roj.com>
Date: Sat, 22 Oct 2016 15:08:35 +0200
Subject: [PATCH] broadcom cfg80211: fix regulatory channel frequency channel
11 is actually 2462, not 2472 (that is channel 13 instead)
Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
Signed-off-by: Arlone Marco <marco.arlone@roj.com>
Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index b777e1b..d71f959 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -204,7 +204,7 @@ static const struct ieee80211_regdomain brcmf_regdom = {
.alpha2 = "99",
.reg_rules = {
/* IEEE 802.11b/g, channels 1..11 */
- REG_RULE(2412-10, 2472+10, 40, 6, 20, 0),
+ REG_RULE(2412-10, 2462+10, 40, 6, 20, 0),
/* If any */
/* IEEE 802.11 channel 14 - Only JP enables
* this and for 802.11b only
--
2.7.4
next parent reply other threads:[~2016-10-28 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACJOhtL-oFTJC5j0_+fdecWExZBKvDy13o+UBzw47tyrvD_SJQ@mail.gmail.com>
[not found] ` <CACJOhtKej4EZ3ufGGUr=Rf1X=hufmKtPLQH3y4x0kK4nNg5U0w@mail.gmail.com>
2016-10-28 16:15 ` Gianfranco Costamagna [this message]
2016-10-28 20:41 ` [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value Arend Van Spriel
2016-11-14 11:22 ` Arend Van Spriel
2016-11-14 11:34 ` Gianfranco Costamagna
2016-11-14 11:36 ` Arend Van Spriel
2016-11-14 11:47 ` Gianfranco Costamagna
2016-11-15 11:10 ` Kalle Valo
2016-11-15 13:13 ` Gianfranco Costamagna
2016-11-15 13:18 ` Nicola Smaldone
2016-11-15 13:21 ` R: " Arlone Marco
2016-11-15 13:52 ` Kalle Valo
2016-11-16 10:38 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=690669269.1124561.1477671348137@mail.yahoo.com \
--to=locutusofborg@debian.org \
--cc=Marco.Arlone@roj.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nsmaldone@tierratelematics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.