All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Joseph Lo <josephl@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nicolas Chauvet <kwizart@gmail.com>
Subject: Re: [PATCH v3 0/8] NVIDIA Tegra clocksource driver improvements
Date: Sat, 1 Jun 2019 16:00:24 +0300	[thread overview]
Message-ID: <6909cb87-8583-4ec8-74b7-a6153aec0246@gmail.com> (raw)
In-Reply-To: <26aeb9f0-5eb1-005a-02c1-4d785fe70331@linaro.org>

31.05.2019 23:31, Daniel Lezcano пишет:
> On 31/05/2019 14:33, Dmitry Osipenko wrote:
>> 31.05.2019 11:26, Peter De Schrijver пишет:
>>> On Fri, May 24, 2019 at 06:32:45PM +0300, Dmitry Osipenko wrote:
>>>> Hello,
>>>>
>>>> This series primarily unifies the driver code across all Tegra SoC
>>>> generations. In a result the clocksources are allocated per-CPU on
>>>> older Tegra's and have a higher rating than the arch-timer, the newer
>>>> Tegra210 is getting support for microsecond clocksource and the driver's
>>>> code is getting much cleaner. Note that arch-timer usage is discouraged on
>>>> all Tegra's due to the time jitter caused by the CPU frequency scaling.
>>>
>>> I think the limitations are more as follows:
>>>
>>> Chip	timer		suffers cpu dvfs jitter		can wakeup from cc7
>>> T20	us-timer	No				Yes
>>> T20	twd timer	Yes				No?
>>> T30	us-timer	No				Yes
>>> T30	twd timer	Yes				No?
>>> T114	us-timer	No				Yes
>>> T114	arch timer	No				Yes
>>> T124	us-timer	No				Yes
>>> T124	arch timer	No				Yes
>>> T210	us-timer	No				Yes
>>> T210	arch timer	No				No
>>> T210	clk_m timer	No				Yes
>>>
>>> right?
>>
>> Doesn't arch timer run off the CPU clock? If yes (that's what I
>> assumed), then it should be affected by the DVFS. Otherwise I'll lower
>> the clocksource's rating for T114/124/132.
>>
>> TWD can't wake CPU from the power-down state, so it's a solid "No" for
>> TWD in the "can wakeup from cc7" column.
> 
> Wouldn't make sense to rename the timer-tegra20.c to timer-tegra.c now ?

Wouldn't hurt, given the refreshment that driver is getting lately. I'll
include a patch for that in the next revision, thanks.

  reply	other threads:[~2019-06-01 13:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 15:32 [PATCH v3 0/8] NVIDIA Tegra clocksource driver improvements Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 1/8] clocksource/drivers/tegra: Support per-CPU timers on all Tegra's Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 2/8] clocksource/drivers/tegra: Unify timer code Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 3/8] clocksource/drivers/tegra: Reset hardware state on init Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 4/8] clocksource/drivers/tegra: Replace readl/writel with relaxed versions Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 5/8] clocksource/drivers/tegra: Release all IRQ's on request_irq() error Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 6/8] clocksource/drivers/tegra: Minor code clean up Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 7/8] clocksource/drivers/tegra: Use SPDX identifier Dmitry Osipenko
2019-05-24 15:32 ` [PATCH v3 8/8] clocksource/drivers/tegra: Support COMPILE_TEST universally Dmitry Osipenko
2019-05-31  8:26 ` [PATCH v3 0/8] NVIDIA Tegra clocksource driver improvements Peter De Schrijver
2019-05-31  8:26   ` Peter De Schrijver
2019-05-31 12:33   ` Dmitry Osipenko
2019-05-31 20:31     ` Daniel Lezcano
2019-06-01 13:00       ` Dmitry Osipenko [this message]
2019-06-03  7:17     ` Peter De Schrijver
2019-06-03  7:17       ` Peter De Schrijver
2019-06-03 11:14       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6909cb87-8583-4ec8-74b7-a6153aec0246@gmail.com \
    --to=digetx@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=josephl@nvidia.com \
    --cc=kwizart@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.