All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log
Date: Mon, 28 Jun 2021 14:13:32 +0300	[thread overview]
Message-ID: <691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru> (raw)
In-Reply-To: <20210518104115.1427712-1-ferruh.yigit@intel.com>

Hi Heinrich,

could you take a look at the patch?

Thanks,
Andrew.

On 5/18/21 1:41 PM, Ferruh Yigit wrote:
> Logging should be converted to dynamic log.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
> index 27dd87611b94..76cc94cb6565 100644
> --- a/drivers/net/nfp/nfp_net_logs.h
> +++ b/drivers/net/nfp/nfp_net_logs.h
> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>   #define ASSERT(x) do { } while (0)
>   #endif
>   
> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -
> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -#define PMD_CPP_LOG(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> -#else
>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
> -#endif
>   
>   extern int nfp_logtype_driver;
>   #define PMD_DRV_LOG(level, fmt, args...) \
> 


  reply	other threads:[~2021-06-28 11:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 10:41 [dpdk-dev] [PATCH] net/nfp: remove compile time log Ferruh Yigit
2021-06-28 11:13 ` Andrew Rybchenko [this message]
2021-07-23 14:14   ` Thomas Monjalon
2021-07-29 12:18     ` Heinrich Kuhn
2021-08-16 14:04       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru \
    --to=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=heinrich.kuhn@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.