All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	glaubitz@physik.fu-berlin.de
Subject: Re: [PATCH v3 2/3] hwmon/ltc2990: Generalise DT to fwnode support
Date: Fri, 16 Aug 2019 00:19:42 +0200	[thread overview]
Message-ID: <6920f2da-3139-6fc8-b02c-3678cc17912e@enpas.org> (raw)
In-Reply-To: <20190815125802.16500-2-max@enpas.org>

On 08/15/2019 02:58 PM, Max Staudt wrote:
> -	if (of_node) {
> -		ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
> -						 data->mode, 2);
> +	if (i2c->dev.of_node || i2c->dev.fwnode) {

One more idea, would it be better here to do the following?

	if (device_property_present(i2c->dev, "lltc,meas-mode")) {
		ret = of_property_read_u32_array(of_node, "lltc,meas-mode",
						 data->mode, 2);
	}

I'm happy to prepare a patch if you wish to have this in - just let me know whether it should be on top of the last one, or instead of it.

Thanks,
Max

  parent reply	other threads:[~2019-08-15 22:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 12:58 [PATCH v3 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-15 12:58 ` [PATCH v3 2/3] hwmon/ltc2990: Generalise DT to fwnode support Max Staudt
2019-08-15 18:33   ` Guenter Roeck
2019-08-15 21:34     ` Max Staudt
2019-08-15 22:19   ` Max Staudt [this message]
2019-08-15 22:43     ` Guenter Roeck
2019-08-16  7:32       ` Geert Uytterhoeven
2019-08-16  8:37       ` Max Staudt
2019-08-16  9:07         ` [PATCH] " Max Staudt
2019-08-16 11:07           ` Geert Uytterhoeven
2019-08-16 12:26             ` Max Staudt
2019-08-16 12:36               ` Geert Uytterhoeven
2019-08-16 12:43                 ` Max Staudt
2019-08-16 13:24                   ` Guenter Roeck
2019-08-15 12:58 ` [PATCH v3 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-16 11:51   ` Wolfram Sang
2019-08-16 12:34     ` Max Staudt
2019-08-16 16:09       ` Wolfram Sang
2019-08-19 11:22         ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6920f2da-3139-6fc8-b02c-3678cc17912e@enpas.org \
    --to=max@enpas.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.