From: Richard Henderson <richard.henderson@linaro.org>
To: Stefan Markovic <stefan.markovic@rt-rk.com>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu, riku.voipio@iki.fi,
philippe.mathieu.daude@gmail.com, aurelien@aurel32.net,
amarkovic@wavecomp.com, smarkovic@wavecomp.com,
pjovanovic@wavecomp.com, pburton@wavecomp.com
Subject: Re: [Qemu-devel] [PATCH v3 38/40] gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub
Date: Mon, 23 Jul 2018 10:03:28 -0700 [thread overview]
Message-ID: <692ad736-c547-7007-dbd3-fdf6a827308f@linaro.org> (raw)
In-Reply-To: <1532004912-13899-39-git-send-email-stefan.markovic@rt-rk.com>
On 07/19/2018 05:55 AM, Stefan Markovic wrote:
> From: James Hogan <james.hogan@mips.com>
>
> nanoMIPS has no ISA bit in the PC, so remove the handling of the low bit
> of the PC in the MIPS gdbstub for nanoMIPS. This prevents the PC being
> read as e.g. 0xbfc00001, and prevents writing to the PC clearing
> MIPS_HFLAG_M16.
>
> Signed-off-by: James Hogan <james.hogan@mips.com>
> Signed-off-by: Yongbok Kim <yongbok.kim@mips.com>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Stefan Markovic <smarkovic@wavecomp.com>
> ---
> target/mips/gdbstub.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
See my comments for 28/40.
r~
next prev parent reply other threads:[~2018-07-23 17:03 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 12:54 [Qemu-devel] [PATCH v3 00/40] Add nanoMIPS support to QEMU Stefan Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 01/40] target/mips: Add preprocessor constants for nanoMIPS Stefan Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 02/40] target/mips: Add nanoMIPS base instruction set opcodes Stefan Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 03/40] target/mips: Add nanoMIPS DSP ASE opcodes Stefan Markovic
2018-07-19 16:28 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 04/40] target/mips: Add decode_nanomips_opc() function Stefan Markovic
2018-07-19 16:39 ` Richard Henderson
2018-07-24 10:56 ` Aleksandar Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 05/40] target/mips: Add nanoMIPS decoding and extraction utilities Stefan Markovic
2018-07-19 16:57 ` Richard Henderson
2018-07-24 11:00 ` Aleksandar Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 06/40] target/mips: Add emulation of misc nanoMIPS 16-bit instructions Stefan Markovic
2018-07-19 18:06 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 07/40] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions Stefan Markovic
2018-07-19 18:28 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 08/40] target/mips: Add emulation of nanoMIPS 16-bit logic instructions Stefan Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 09/40] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions Stefan Markovic
2018-07-19 18:34 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 10/40] target/mips: Add emulation of some common nanoMIPS 32-bit instructions Stefan Markovic
2018-07-19 18:52 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 11/40] target/mips: Add emulation of nanoMIPS 48-bit instructions Stefan Markovic
2018-07-19 19:01 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 12/40] target/mips: Add emulation of nanoMIPS FP instructions Stefan Markovic
2018-07-19 19:03 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 13/40] target/mips: Add emulation of misc nanoMIPS instructions (pool32a0) Stefan Markovic
2018-07-19 19:08 ` Richard Henderson
2018-07-25 15:38 ` Aleksandar Markovic
2018-07-25 19:07 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 14/40] target/mips: Add emulation of misc nanoMIPS instructions (pool32axf) Stefan Markovic
2018-07-19 19:13 ` Richard Henderson
2018-07-20 16:15 ` Aleksandar Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 15/40] target/mips: Add emulation of misc nanoMIPS instructions (pool p_lsx) Stefan Markovic
2018-07-19 19:19 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 16/40] target/mips: Implement emulation of nanoMIPS ROTX instruction Stefan Markovic
2018-07-19 19:19 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 17/40] target/mips: Implement emulation of nanoMIPS EXTW instruction Stefan Markovic
2018-07-19 20:59 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 18/40] target/mips: Add emulation of nanoMIPS 32-bit load and store instructions Stefan Markovic
2018-07-20 4:59 ` Richard Henderson
2018-07-25 15:46 ` Aleksandar Markovic
2018-07-25 19:18 ` Richard Henderson
2018-07-25 19:32 ` Peter Maydell
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 19/40] target/mips: Add emulation of nanoMIPS branch instructions Stefan Markovic
2018-07-20 5:28 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 20/40] target/mips: Implement MT ASE support for nanoMIPS Stefan Markovic
2018-07-21 15:19 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 21/40] target/mips: Implement DSP " Stefan Markovic
2018-07-21 15:52 ` Richard Henderson
2018-07-21 18:04 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 22/40] target/mips: Add handling of branch delay slots " Stefan Markovic
2018-07-21 18:03 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 23/40] target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair Stefan Markovic
2018-07-21 18:15 ` Richard Henderson
2018-07-23 17:21 ` Aleksandar Markovic
2018-07-27 15:29 ` Aleksandar Markovic
2018-07-27 15:50 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 24/40] target/mips: Add updating BadInstr and BadInstrP registers for nanoMIPS Stefan Markovic
2018-07-23 16:36 ` Richard Henderson
2018-07-24 10:47 ` Aleksandar Markovic
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 25/40] target/mips: Add updating CP0 BadInstrX register for nanoMIPs only Stefan Markovic
2018-07-23 16:35 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 26/40] target/mips: Implement CP0 Config0.WR bit functionality Stefan Markovic
2018-07-23 16:46 ` Richard Henderson
2018-07-19 12:54 ` [Qemu-devel] [PATCH v3 27/40] target/mips: Adjust behavior of Config3's ISAOnExc bit for nanoMIPS Stefan Markovic
2018-07-23 16:48 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 28/40] target/mips: Adjust exception_resume_pc() " Stefan Markovic
2018-07-23 16:54 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 29/40] target/mips: Adjust set_hflags_for_handler() " Stefan Markovic
2018-07-23 16:54 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 30/40] target/mips: Adjust set_pc() " Stefan Markovic
2018-07-23 16:55 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 31/40] target/mips: Fix ERET/ERETNC behavior related to ADEL exception Stefan Markovic
2018-07-23 16:56 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 32/40] elf: Add nanoMIPS specific variations in ELF header fields Stefan Markovic
2018-07-23 16:59 ` Richard Henderson
2018-07-23 17:39 ` Aleksandar Markovic
2018-07-23 17:43 ` Aleksandar Markovic
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 33/40] elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too Stefan Markovic
2018-07-23 17:01 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 34/40] linux-user: Don't check FCR31_NAN2008 bit for nanoMIPS Stefan Markovic
2018-07-23 17:02 ` Richard Henderson
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 35/40] mips_malta: Add basic nanoMIPS boot code for MIPS' Malta Stefan Markovic
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 36/40] mips_malta: Setup GT64120 BARs in nanoMIPS bootloader Stefan Markovic
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 37/40] mips_malta: Fix semihosting argument passing for nanoMIPS bare metal Stefan Markovic
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 38/40] gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub Stefan Markovic
2018-07-23 17:03 ` Richard Henderson [this message]
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 39/40] gdbstub: Add XML support for GDB for nanoMIPS Stefan Markovic
2018-07-19 12:55 ` [Qemu-devel] [PATCH v3 40/40] target/mips: Add definition of nanoMIPS I7200 CPU Stefan Markovic
2018-07-23 17:05 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=692ad736-c547-7007-dbd3-fdf6a827308f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=laurent@vivier.eu \
--cc=pburton@wavecomp.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=pjovanovic@wavecomp.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=smarkovic@wavecomp.com \
--cc=stefan.markovic@rt-rk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.