From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5C0C433B4 for ; Thu, 29 Apr 2021 11:25:12 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 74BA46142A for ; Thu, 29 Apr 2021 11:25:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74BA46142A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 608584110F; Thu, 29 Apr 2021 13:25:10 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 84291410DD for ; Thu, 29 Apr 2021 13:25:09 +0200 (CEST) IronPort-SDR: KQRnP5H0YeCI0kxXesVEUhyJXbRsRRVZShz8TBADpxmE5Zb/alGvmHGmxNJivdXzJ6wlOXzEOs EkfCxdoZopAg== X-IronPort-AV: E=McAfee;i="6200,9189,9968"; a="197028930" X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="197028930" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 04:25:08 -0700 IronPort-SDR: CvX4zXhXQWcry8xOr0fzfb3XYawdBxA7MzHh4JENAkrdFlTZUDAgQ05wsnhP8ep38XL4JScWoL 7/RYy2nyi0YQ== X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="526903972" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.65]) ([10.213.208.65]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 04:25:05 -0700 To: "Min Hu (Connor)" , "Singh, Aman Deep" , "'dev@dpdk.org'" Cc: "Mcnamara, John" , "Kovacevic, Marko" , "Burakov, Anatoly" , "andrew.rybchenko@oktetlabs.ru" , "thomas@monjalon.net" , "Li, Xiaoyun" References: <7d3abc78770645a78fd2d20061b2d686@intel.com> <63ae4695-9ffd-e854-b9d4-d6257b24768a@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <6936cb8f-baae-0554-7cd1-af448f8269bd@intel.com> Date: Thu, 29 Apr 2021 12:25:01 +0100 MIME-Version: 1.0 In-Reply-To: <63ae4695-9ffd-e854-b9d4-d6257b24768a@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2021 11:57 AM, Min Hu (Connor) wrote: > Thanks Aman. > > Hi, Thomas, Ferruh, any other comments about this patch? > Hi Connor, There is no outstanding comments, also the patch has review/test tags in place. But the multi-process support may affect many operations, and assuming it is not critical for this release, to prevent any unexpected side affects I am for getting this patch early next release instead of this release. This gives more time in next release to address any unexpected issue. Thanks, ferruh > 在 2021/4/28 20:10, Singh, Aman Deep 写道: >> This patch adds multi-process support for testpmd. >> >> The test cmd example as follows: >> >> the primary cmd: >> >> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ >> >> --rxq=4 --txq=4 --num-procs=2 --proc-id=0 >> >> the secondary cmd: >> >> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ >> >> --rxq=4 --txq=4 --num-procs=2 --proc-id=1 >> >> Signed-off-by: Min Hu (Connor) > >> >> Signed-off-by: Lijun Ou > >> >> Acked-by: Xiaoyun Li > >> >> Acked-by: Ajit Khaparde > > >> >> Reviewed-by: Ferruh Yigit > > >> >> >> >> Acked-by: Aman Deep Singh > > >> >> Tested-by: Aman Deep Singh > > >>