From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0A4BECAAD8 for ; Sun, 18 Sep 2022 15:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbiIRPzl (ORCPT ); Sun, 18 Sep 2022 11:55:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbiIRPzL (ORCPT ); Sun, 18 Sep 2022 11:55:11 -0400 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12D9C20F75 for ; Sun, 18 Sep 2022 08:54:17 -0700 (PDT) Received: from fsav313.sakura.ne.jp (fsav313.sakura.ne.jp [153.120.85.144]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 28IFqmkS092637; Mon, 19 Sep 2022 00:52:49 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav313.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav313.sakura.ne.jp); Mon, 19 Sep 2022 00:52:48 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav313.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 28IFqmON092633 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Mon, 19 Sep 2022 00:52:48 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: <693b572a-6436-14e6-442c-c8f2f361ed94@I-love.SAKURA.ne.jp> Date: Mon, 19 Sep 2022 00:52:45 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: WARNING: locking bug in inet_autobind Content-Language: en-US To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <00000000000033a0120588fac894@google.com> Cc: netdev@vger.kernel.org, syzbot , syzkaller-bugs@googlegroups.com From: Tetsuo Handa In-Reply-To: <00000000000033a0120588fac894@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org syzbot is reporting locking bug in inet_autobind(), for commit 37159ef2c1ae1e69 ("l2tp: fix a lockdep splat") started calling lockdep_set_class_and_name(&sk->sk_lock.slock, &l2tp_socket_class, "l2tp_sock") in l2tp_tunnel_create() (which is currently in l2tp_tunnel_register()). How can we fix this problem? ------------[ cut here ]------------ class->name=slock-AF_INET6 lock->name=l2tp_sock lock->key=l2tp_socket_class WARNING: CPU: 2 PID: 9237 at kernel/locking/lockdep.c:940 look_up_lock_class+0xcc/0x140 Modules linked in: CPU: 2 PID: 9237 Comm: a.out Not tainted 6.0.0-rc5-00094-ga335366bad13-dirty #860 Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 RIP: 0010:look_up_lock_class+0xcc/0x140 On 2019/05/16 14:46, syzbot wrote: > HEAD commit:    35c99ffa Merge tag 'for_linus' of git://git.kernel.org/pub.. > git tree:       net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=10e970f4a00000 > kernel config:  https://syzkaller.appspot.com/x/.config?x=82f0809e8f0a8c87 > dashboard link: https://syzkaller.appspot.com/bug?extid=94cc2a66fc228b23f360 > compiler:       gcc (GCC) 9.0.0 20181231 (experimental) C reproducer is available at https://syzkaller.appspot.com/text?tag=ReproC&x=15062310080000 .