From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>, vinschen@redhat.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH net] r8169: disable TSO on a single version of RTL8168c to fix performance
Date: Wed, 20 Nov 2019 07:49:16 +0100 [thread overview]
Message-ID: <6947347d-376e-ec13-a62c-5a67ed66c5aa@gmail.com> (raw)
In-Reply-To: <20191119.164257.971575741444657962.davem@davemloft.net>
On 20.11.2019 01:42, David Miller wrote:
> From: Corinna Vinschen <vinschen@redhat.com>
> Date: Tue, 19 Nov 2019 10:09:39 +0100
>
>> During performance testing, I found that one of my r8169 NICs suffered
>> a major performance loss, a 8168c model.
>>
>> Running netperf's TCP_STREAM test didn't return the expected
>> throughput of > 900 Mb/s, but rather only about 22 Mb/s. Strange
>> enough, running the TCP_MAERTS and UDP_STREAM tests all returned with
>> throughput > 900 Mb/s, as did TCP_STREAM with the other r8169 NICs I can
>> test (either one of 8169s, 8168e, 8168f).
>>
>> Bisecting turned up commit 93681cd7d94f83903cb3f0f95433d10c28a7e9a5,
>> "r8169: enable HW csum and TSO" as the culprit.
>>
>> I added my 8168c version, RTL_GIGA_MAC_VER_22, to the code
>> special-casing the 8168evl as per the patch below. This fixed the
>> performance problem for me.
>>
>> Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO")
>> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
>
> Applied, but it would be really nice to know why this is happening
> instead of just turning it off completely.
>
For RTL8168e-vl Realtek confirmed a HW issue, for this RTL8168c version
supposedly it's the same as other chip versions are working fine with TSO.
next prev parent reply other threads:[~2019-11-20 6:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 9:55 [PATCH net-next] r8169: disable TSO on a single version of RTL8168c to fix performance Corinna Vinschen
2019-11-18 19:33 ` Heiner Kallweit
2019-11-19 9:09 ` [PATCH net] " Corinna Vinschen
2019-11-19 18:01 ` Heiner Kallweit
2019-11-20 0:42 ` David Miller
2019-11-20 6:49 ` Heiner Kallweit [this message]
2019-11-19 9:12 ` [PATCH net-next] " Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6947347d-376e-ec13-a62c-5a67ed66c5aa@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.