From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD65C4332F for ; Mon, 27 Sep 2021 16:40:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C1D96108E for ; Mon, 27 Sep 2021 16:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235507AbhI0QmR (ORCPT ); Mon, 27 Sep 2021 12:42:17 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:35632 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235463AbhI0QmP (ORCPT ); Mon, 27 Sep 2021 12:42:15 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18RAccN9016754; Mon, 27 Sep 2021 18:40:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=3cUaM13ESIaimd9wicHJ6CmL5u8o5wVuRy7GsckzHkI=; b=Rhe/st5cXpwbNhNGonO107ZDod1wya4ZWYrLBd8zipZ+F2FziOwCzcQig9+UISeRbx5d WobWAtYSh2LuYPH1Pu44iF74wWu2wo6jgEF0+lI11hcyXG2iP1C9Rb49KVw0lbvZsCiY o8/UIHflStKEqe2ljuvHeWYYiyElaLj+baJxTei7unOBUemah7aqJhCJKMQrxdWlzaIY mp6rBTzs6gpH/p+LlkFmLv9xKt2WXzU/7AHD/XEYo6B5zIuCILYO3uOIi5jnB6ftOnOo RNWx1ynxmlg7pNnvItwXYGJ3UXU3C2ITywlsItNXTKXWA43V7sGCUroJNU8509DGPgkd 8w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3bbau5294a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Sep 2021 18:40:18 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D73BD10002A; Mon, 27 Sep 2021 18:40:17 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id CE4782C4213; Mon, 27 Sep 2021 18:40:17 +0200 (CEST) Received: from [10.211.13.71] (10.75.127.47) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 27 Sep 2021 18:40:16 +0200 Subject: Re: [PATCH v3 0/7] iio: adc: stm32-adc: add internal channels support To: Olivier Moysan , Alexandre Torgue , Fabrice Gasnier , Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin , Rob Herring CC: , , , , References: <20210924083410.12332-1-olivier.moysan@foss.st.com> From: Fabrice Gasnier Message-ID: <6948e726-1a1c-7143-dd36-710e8396c63b@foss.st.com> Date: Mon, 27 Sep 2021 18:40:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210924083410.12332-1-olivier.moysan@foss.st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-27_06,2021-09-24_02,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/24/21 10:34 AM, Olivier Moysan wrote: > This patchset adds support of ADC2 internal channels VDDCORE, VREFINT and VBAT > on STM32MP15x SoCs. The generic IIO channel bindings is also introduced here > to provide this feature. The legacy channel binding is kept for backward compatibility. > > Changes in v2: > - Add 'deprecated' to channels legacy properties in ADC bindings > - Add set/clr service for common registers, to make code more generic in > internal channels enable/disable services. > - Expose vrefint channel as a processed channel to return > the actual value of vrefp. > - Minor code improvements > > Changes in v3: > - fix vrefint sampling time check. > > Olivier Moysan (7): > dt-bindings: iio: stm32-adc: add generic channel binding > dt-bindings: iio: stm32-adc: add nvmem support for vrefint internal > channel > iio: adc: stm32-adc: split channel init into several routines > iio: adc: stm32-adc: add support of generic channels binding > iio: adc: stm32-adc: add support of internal channels Hi Olivier, I've one remark on patch "... add support of internal channels". For the other patches, you can add my Reviewed-by: Fabrice Gasnier Thanks! Fabrice > iio: adc: stm32-adc: add vrefint calibration support > iio: adc: stm32-adc: use generic binding for sample-time> > .../bindings/iio/adc/st,stm32-adc.yaml | 108 ++++- > drivers/iio/adc/stm32-adc-core.h | 8 + > drivers/iio/adc/stm32-adc.c | 426 ++++++++++++++++-- > 3 files changed, 487 insertions(+), 55 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4A3C433EF for ; Mon, 27 Sep 2021 16:41:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA2CB60EE2 for ; Mon, 27 Sep 2021 16:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA2CB60EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8EDBbCVoibACUdksWRS2IcX9wvvGA3qqGHk1YN8d4aI=; b=jveyvd3HoIjlDf7JZtMJHf/Fkx x/9oMcDFv5qpLOahS0McvNJuuFMBJdfXXeG5CsNCiiokxP9uZnDqt5YZVFtGHMTu8LedVQ53ZTHrd TZv3aUJe/YpLvFAQb3thhKxWCspD+6XPKBYlWjCHpKrOBvxRHGonl65aOQ7sa3Yi/rHQznTZGqgoT WQ9xUhzkFNp8sdRENx28MfjYYMzA2MgrUaoXCszrTRv8zuZTejoqm9aiK/5T+NVx1rUNEJtlivbNw wloBcNhQxpfqGxFCKYfANBk/9ukZK9q7T1QEm/y3Wg19iWJLNz/7l124vW0dgriGebwgUQY7haWV2 BrqOzLug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUtg4-003PZx-J8; Mon, 27 Sep 2021 16:40:28 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUtfz-003PY3-I7 for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 16:40:25 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18RAccN9016754; Mon, 27 Sep 2021 18:40:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=3cUaM13ESIaimd9wicHJ6CmL5u8o5wVuRy7GsckzHkI=; b=Rhe/st5cXpwbNhNGonO107ZDod1wya4ZWYrLBd8zipZ+F2FziOwCzcQig9+UISeRbx5d WobWAtYSh2LuYPH1Pu44iF74wWu2wo6jgEF0+lI11hcyXG2iP1C9Rb49KVw0lbvZsCiY o8/UIHflStKEqe2ljuvHeWYYiyElaLj+baJxTei7unOBUemah7aqJhCJKMQrxdWlzaIY mp6rBTzs6gpH/p+LlkFmLv9xKt2WXzU/7AHD/XEYo6B5zIuCILYO3uOIi5jnB6ftOnOo RNWx1ynxmlg7pNnvItwXYGJ3UXU3C2ITywlsItNXTKXWA43V7sGCUroJNU8509DGPgkd 8w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3bbau5294a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Sep 2021 18:40:18 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D73BD10002A; Mon, 27 Sep 2021 18:40:17 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id CE4782C4213; Mon, 27 Sep 2021 18:40:17 +0200 (CEST) Received: from [10.211.13.71] (10.75.127.47) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 27 Sep 2021 18:40:16 +0200 Subject: Re: [PATCH v3 0/7] iio: adc: stm32-adc: add internal channels support To: Olivier Moysan , Alexandre Torgue , Fabrice Gasnier , Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin , Rob Herring CC: , , , , References: <20210924083410.12332-1-olivier.moysan@foss.st.com> From: Fabrice Gasnier Message-ID: <6948e726-1a1c-7143-dd36-710e8396c63b@foss.st.com> Date: Mon, 27 Sep 2021 18:40:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210924083410.12332-1-olivier.moysan@foss.st.com> Content-Language: en-US X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-27_06,2021-09-24_02,2020-04-07_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_094023_972167_AC52C2F9 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/24/21 10:34 AM, Olivier Moysan wrote: > This patchset adds support of ADC2 internal channels VDDCORE, VREFINT and VBAT > on STM32MP15x SoCs. The generic IIO channel bindings is also introduced here > to provide this feature. The legacy channel binding is kept for backward compatibility. > > Changes in v2: > - Add 'deprecated' to channels legacy properties in ADC bindings > - Add set/clr service for common registers, to make code more generic in > internal channels enable/disable services. > - Expose vrefint channel as a processed channel to return > the actual value of vrefp. > - Minor code improvements > > Changes in v3: > - fix vrefint sampling time check. > > Olivier Moysan (7): > dt-bindings: iio: stm32-adc: add generic channel binding > dt-bindings: iio: stm32-adc: add nvmem support for vrefint internal > channel > iio: adc: stm32-adc: split channel init into several routines > iio: adc: stm32-adc: add support of generic channels binding > iio: adc: stm32-adc: add support of internal channels Hi Olivier, I've one remark on patch "... add support of internal channels". For the other patches, you can add my Reviewed-by: Fabrice Gasnier Thanks! Fabrice > iio: adc: stm32-adc: add vrefint calibration support > iio: adc: stm32-adc: use generic binding for sample-time> > .../bindings/iio/adc/st,stm32-adc.yaml | 108 ++++- > drivers/iio/adc/stm32-adc-core.h | 8 + > drivers/iio/adc/stm32-adc.c | 426 ++++++++++++++++-- > 3 files changed, 487 insertions(+), 55 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel