From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1] doc: change doc line length limit in
	contributors guide
Date: Thu, 11 May 2017 17:23:00 +0200
Message-ID: <6951954.sJVyEfo4GT@xps>
References: <1494511780-5732-1-git-send-email-john.mcnamara@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: John McNamara <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 75AB2282
 for <dev@dpdk.org>; Thu, 11 May 2017 17:23:02 +0200 (CEST)
In-Reply-To: <1494511780-5732-1-git-send-email-john.mcnamara@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/05/2017 16:09, John McNamara:
> The DPDK documentation guidelines state that lines should be wrapped as
> follows:
> 
> * The recommended style for the DPDK documentation is to put sentences on
>   separate lines. This allows for easier reviewing of patches. ...
> * Long sentences should be wrapped at 120 characters +/- 10 characters.
>   They should be wrapped at words.
> 
>   http://dpdk.org/doc/guides/contributing/documentation.html#line-length
> 
> However, in practice, users almost never submit doc patches in this format.
> Instead most users wrap their doc patches at 80 characters.
> 
> This patch updates the documentation contributors guide to reflect this
> as the recommended guideline.
> 
> Signed-off-by: John McNamara <john.mcnamara@intel.com>
> ---
> --- a/doc/guides/contributing/documentation.rst
> +++ b/doc/guides/contributing/documentation.rst
> @@ -282,33 +282,21 @@ The additional guidelines below reiterate or expand upon those guidelines.
>  Line Length
>  ~~~~~~~~~~~
>  
> -* The recommended style for the DPDK documentation is to put sentences on separate lines.
> -  This allows for easier reviewing of patches.
> -  Multiple sentences which are not separated by a blank line are joined automatically into paragraphs, for example::
> +* Lines in sentences should be less than 80 characters and wrapped at
> +  words. Multiple sentences which are not separated by a blank line are joined
> +  automatically into paragraphs.

Why not keep the recommendation of separating sentences?

> +     testpmd -l 2-3 -n 4 \
> +             --vdev=virtio_user0,path=/dev/vhost-net,queues=2,queue_size=1024 \
> +             -- -i --txqflags=0x0 --disable-hw-vlan --enable-lro \
> +             --enable-rx-cksum --txq=2 --rxq=2 --rxd=1024  --txd=1024

Garbage?