From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 12/20] rtnetlink: Update ipmr_rtm_dumplink for
 strict data checking
Date: Sun, 7 Oct 2018 19:32:49 -0600
Message-ID: <69539a4e-be1e-5222-a022-771783acd100@gmail.com>
References: <20181004213355.14899-1-dsahern@kernel.org>
 <20181004213355.14899-13-dsahern@kernel.org>
 <20181007104010.pb5qaatg2ydbutjl@brauner.io>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net, jbenc@redhat.com,
        stephen@networkplumber.org
To: Christian Brauner <christian@brauner.io>,
        David Ahern <dsahern@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f195.google.com ([209.85.215.195]:41601 "EHLO
        mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726387AbeJHImE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 8 Oct 2018 04:42:04 -0400
Received: by mail-pg1-f195.google.com with SMTP id 23-v6so7065309pgc.8
        for <netdev@vger.kernel.org>; Sun, 07 Oct 2018 18:32:51 -0700 (PDT)
In-Reply-To: <20181007104010.pb5qaatg2ydbutjl@brauner.io>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/7/18 4:40 AM, Christian Brauner wrote:
>> @@ -2718,6 +2743,13 @@ static int ipmr_rtm_dumplink(struct sk_buff *skb, struct netlink_callback *cb)
>>  	unsigned int e = 0, s_e;
>>  	struct mr_table *mrt;
>>  
>> +	if (cb->strict_check) {
>> +		int err = ipmr_valid_dumplink(cb->nlh, cb->extack);
>> +
>> +		if (err)
>> +			return err;
> 
> Nit: can we remove the unnecessary \n, please.

Coding standards dictate a newline between declarations and code. And
that is my preference too.