All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Abhishek Anand Kulkarni <kulkarniabhishekanand@gmail.com>,
	gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Add spaces before and after logical '&'
Date: Tue, 17 Aug 2021 08:54:19 +0200	[thread overview]
Message-ID: <6957e465-7250-c5f4-759f-c802391268e0@gmail.com> (raw)
In-Reply-To: <20210817022628.GA6595@abhishek-Lenovo-ideapad-110-15AST>

On 8/17/21 4:26 AM, Abhishek Anand Kulkarni wrote:
> Fix Checkpatch.pl warning to add space before and after logical '&'
> operator
> 
> Signed-off-by: Abhishek Anand Kulkarni <kulkaraniabhishekanand@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> index a7f966a..570f25f 100644
> --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> @@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
>   		struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
>   
>   		wep->Length = len;
> -		keyindex = key->KeyIndex&0x7fffffff;
> +		keyindex = key->KeyIndex & 0x7fffffff;
>   		wep->KeyIndex = keyindex ;
>   		wep->KeyLength = key->KeyLength;
>   
> 

Hi Abhishek,

there is already a pending patch that addresses this.

https://lore.kernel.org/linux-staging/20210816155818.24005-9-straube.linux@gmail.com/T/#u

Regards,
Michael

      reply	other threads:[~2021-08-17  6:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  2:26 [PATCH] staging: r8188eu: Add spaces before and after logical '&' Abhishek Anand Kulkarni
2021-08-17  6:54 ` Michael Straube [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6957e465-7250-c5f4-759f-c802391268e0@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kulkarniabhishekanand@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.