From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829D5C47082 for ; Tue, 8 Jun 2021 16:58:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E6FA61285 for ; Tue, 8 Jun 2021 16:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E6FA61285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LtWiJYayJVJDwnILwuvGae3/GkHtCYyQ+Q/lnhEvOAE=; b=0Sj+PKp1dK4qVu0LYeYrzZ9OR1 zLDbrL0IWNPFJi6QZ62S0growevaZHTh5D9baxcyHoM+9nD9PoVsxLmdpMripBafCbeBYMHgiiZB6 V9dUTil6dTkTKqnqqPVMbxG9Al1X3zLaUirV4seyA8NNppBklohuEMOD1O/OYPHJ2aspoQ2DAwAPA gz2Yis2zePz2ymtBzXIunzJhHSkG8+q+Ld86ywmgeTDYvz0c2tcXLVgUeaCc5LtZphQMexFcIaHOp B7DjlNQbmZv88OdfhdOhiULSrg/yVUudiqR8ZirJFiK86493B2CnFdkKJqXzDF3FDO18aTDCbacZi XcvyqdWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqf23-009fFq-Qu; Tue, 08 Jun 2021 16:56:52 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqf1v-009fCR-Al for linux-arm-kernel@lists.infradead.org; Tue, 08 Jun 2021 16:56:48 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 158GpTtB008149; Tue, 8 Jun 2021 18:56:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=xmXXy0WciX654IwlpzmNZ/gVDr1D3/TyBFil1GVZFBY=; b=gskQBmP72sCEyBu8AD764fnP5x4b1XUc3ETw4WCBMPta73SdkH+tsugwBgA7W6MVDPXP 4HBkswgPDFllrEjDcEM41QnE3IE8lMOXMylFxxRZRRHW1XCvUWBRbG/RZDlHvb3vi2Jy 1Y71LaPSC+aT6UsmWkr4uQItpFBBQnftNO0dfuV+TcMomUxS/uElDYHAdD5e57bm9TlA iIIfEwcXbDZ+sQgxAaPwSOgV4A8AjjLGCCK9ff4RRMESUonJdZ3fCouCCBV/dPM88Ycv MBHHudSBo9es0N2We16yD2CYcG2BIyHY2Ikk/fTktnNg1d4gs9jeTdzi4lOqTAdfP6bZ Eg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3924rmjyge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Jun 2021 18:56:33 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5FEDD100034; Tue, 8 Jun 2021 18:56:31 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1FC5322E7E5; Tue, 8 Jun 2021 18:56:31 +0200 (CEST) Received: from lmecxl0993.lme.st.com (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 18:56:30 +0200 Subject: Re: [PATCH] drm/stm: Remove usage of drm_display_mode_to_videomode() To: Marek Vasut , CC: Alexandre Torgue , Antonio Borneo , Benjamin Gaignard , Maxime Coquelin , Sam Ravnborg , Vincent Abriou , Yannick Fertre , , References: <20210607172457.14471-1-marex@denx.de> From: Philippe CORNU Message-ID: <695b7ef5-480f-dc3e-74f5-99148add22d7@foss.st.com> Date: Tue, 8 Jun 2021 18:56:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210607172457.14471-1-marex@denx.de> Content-Language: en-US X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-08_11:2021-06-04, 2021-06-08 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_095643_675600_99F533DC X-CRM114-Status: GOOD ( 24.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, Applied on drm-misc-next. Note: I added Yannick Tested-by from the last (identical) December version https://patchwork.freedesktop.org/patch/409968 Many thanks for your patch, Philippe :-) On 6/7/21 7:24 PM, Marek Vasut wrote: > There is not much value in the extra conversion step, the calculations > required for the LTDC IP are different than what is used in the > drm_display_mode_to_videomode(), so just do the right ones in the LTDC > driver right away. > > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Antonio Borneo > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Philippe Cornu > Cc: Sam Ravnborg > Cc: Vincent Abriou > Cc: Yannick Fertre > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > To: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/stm/ltdc.c | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..08b71248044d 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -531,7 +531,6 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) > struct drm_encoder *encoder = NULL; > struct drm_bridge *bridge = NULL; > struct drm_display_mode *mode = &crtc->state->adjusted_mode; > - struct videomode vm; > u32 hsync, vsync, accum_hbp, accum_vbp, accum_act_w, accum_act_h; > u32 total_width, total_height; > u32 bus_flags = 0; > @@ -570,31 +569,33 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) > } > } > > - drm_display_mode_to_videomode(mode, &vm); > - > DRM_DEBUG_DRIVER("CRTC:%d mode:%s\n", crtc->base.id, mode->name); > - DRM_DEBUG_DRIVER("Video mode: %dx%d", vm.hactive, vm.vactive); > + DRM_DEBUG_DRIVER("Video mode: %dx%d", mode->hdisplay, mode->vdisplay); > DRM_DEBUG_DRIVER(" hfp %d hbp %d hsl %d vfp %d vbp %d vsl %d\n", > - vm.hfront_porch, vm.hback_porch, vm.hsync_len, > - vm.vfront_porch, vm.vback_porch, vm.vsync_len); > + mode->hsync_start - mode->hdisplay, > + mode->htotal - mode->hsync_end, > + mode->hsync_end - mode->hsync_start, > + mode->vsync_start - mode->vdisplay, > + mode->vtotal - mode->vsync_end, > + mode->vsync_end - mode->vsync_start); > > /* Convert video timings to ltdc timings */ > - hsync = vm.hsync_len - 1; > - vsync = vm.vsync_len - 1; > - accum_hbp = hsync + vm.hback_porch; > - accum_vbp = vsync + vm.vback_porch; > - accum_act_w = accum_hbp + vm.hactive; > - accum_act_h = accum_vbp + vm.vactive; > - total_width = accum_act_w + vm.hfront_porch; > - total_height = accum_act_h + vm.vfront_porch; > + hsync = mode->hsync_end - mode->hsync_start - 1; > + vsync = mode->vsync_end - mode->vsync_start - 1; > + accum_hbp = mode->htotal - mode->hsync_start - 1; > + accum_vbp = mode->vtotal - mode->vsync_start - 1; > + accum_act_w = accum_hbp + mode->hdisplay; > + accum_act_h = accum_vbp + mode->vdisplay; > + total_width = mode->htotal - 1; > + total_height = mode->vtotal - 1; > > /* Configures the HS, VS, DE and PC polarities. Default Active Low */ > val = 0; > > - if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH) > + if (mode->flags & DRM_MODE_FLAG_PHSYNC) > val |= GCR_HSPOL; > > - if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) > + if (mode->flags & DRM_MODE_FLAG_PVSYNC) > val |= GCR_VSPOL; > > if (bus_flags & DRM_BUS_FLAG_DE_LOW) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CB6C47082 for ; Tue, 8 Jun 2021 16:56:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BE6C6024A for ; Tue, 8 Jun 2021 16:56:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE6C6024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B14D6E105; Tue, 8 Jun 2021 16:56:39 +0000 (UTC) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7619B6E105 for ; Tue, 8 Jun 2021 16:56:37 +0000 (UTC) Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 158GpTtB008149; Tue, 8 Jun 2021 18:56:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=xmXXy0WciX654IwlpzmNZ/gVDr1D3/TyBFil1GVZFBY=; b=gskQBmP72sCEyBu8AD764fnP5x4b1XUc3ETw4WCBMPta73SdkH+tsugwBgA7W6MVDPXP 4HBkswgPDFllrEjDcEM41QnE3IE8lMOXMylFxxRZRRHW1XCvUWBRbG/RZDlHvb3vi2Jy 1Y71LaPSC+aT6UsmWkr4uQItpFBBQnftNO0dfuV+TcMomUxS/uElDYHAdD5e57bm9TlA iIIfEwcXbDZ+sQgxAaPwSOgV4A8AjjLGCCK9ff4RRMESUonJdZ3fCouCCBV/dPM88Ycv MBHHudSBo9es0N2We16yD2CYcG2BIyHY2Ikk/fTktnNg1d4gs9jeTdzi4lOqTAdfP6bZ Eg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3924rmjyge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Jun 2021 18:56:33 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5FEDD100034; Tue, 8 Jun 2021 18:56:31 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1FC5322E7E5; Tue, 8 Jun 2021 18:56:31 +0200 (CEST) Received: from lmecxl0993.lme.st.com (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 18:56:30 +0200 Subject: Re: [PATCH] drm/stm: Remove usage of drm_display_mode_to_videomode() To: Marek Vasut , References: <20210607172457.14471-1-marex@denx.de> From: Philippe CORNU Message-ID: <695b7ef5-480f-dc3e-74f5-99148add22d7@foss.st.com> Date: Tue, 8 Jun 2021 18:56:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210607172457.14471-1-marex@denx.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-08_11:2021-06-04, 2021-06-08 signatures=0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Borneo , Benjamin Gaignard , Yannick Fertre , Alexandre Torgue , Vincent Abriou , Maxime Coquelin , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, Applied on drm-misc-next. Note: I added Yannick Tested-by from the last (identical) December version https://patchwork.freedesktop.org/patch/409968 Many thanks for your patch, Philippe :-) On 6/7/21 7:24 PM, Marek Vasut wrote: > There is not much value in the extra conversion step, the calculations > required for the LTDC IP are different than what is used in the > drm_display_mode_to_videomode(), so just do the right ones in the LTDC > driver right away. > > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Antonio Borneo > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Philippe Cornu > Cc: Sam Ravnborg > Cc: Vincent Abriou > Cc: Yannick Fertre > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > To: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/stm/ltdc.c | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..08b71248044d 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -531,7 +531,6 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) > struct drm_encoder *encoder = NULL; > struct drm_bridge *bridge = NULL; > struct drm_display_mode *mode = &crtc->state->adjusted_mode; > - struct videomode vm; > u32 hsync, vsync, accum_hbp, accum_vbp, accum_act_w, accum_act_h; > u32 total_width, total_height; > u32 bus_flags = 0; > @@ -570,31 +569,33 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) > } > } > > - drm_display_mode_to_videomode(mode, &vm); > - > DRM_DEBUG_DRIVER("CRTC:%d mode:%s\n", crtc->base.id, mode->name); > - DRM_DEBUG_DRIVER("Video mode: %dx%d", vm.hactive, vm.vactive); > + DRM_DEBUG_DRIVER("Video mode: %dx%d", mode->hdisplay, mode->vdisplay); > DRM_DEBUG_DRIVER(" hfp %d hbp %d hsl %d vfp %d vbp %d vsl %d\n", > - vm.hfront_porch, vm.hback_porch, vm.hsync_len, > - vm.vfront_porch, vm.vback_porch, vm.vsync_len); > + mode->hsync_start - mode->hdisplay, > + mode->htotal - mode->hsync_end, > + mode->hsync_end - mode->hsync_start, > + mode->vsync_start - mode->vdisplay, > + mode->vtotal - mode->vsync_end, > + mode->vsync_end - mode->vsync_start); > > /* Convert video timings to ltdc timings */ > - hsync = vm.hsync_len - 1; > - vsync = vm.vsync_len - 1; > - accum_hbp = hsync + vm.hback_porch; > - accum_vbp = vsync + vm.vback_porch; > - accum_act_w = accum_hbp + vm.hactive; > - accum_act_h = accum_vbp + vm.vactive; > - total_width = accum_act_w + vm.hfront_porch; > - total_height = accum_act_h + vm.vfront_porch; > + hsync = mode->hsync_end - mode->hsync_start - 1; > + vsync = mode->vsync_end - mode->vsync_start - 1; > + accum_hbp = mode->htotal - mode->hsync_start - 1; > + accum_vbp = mode->vtotal - mode->vsync_start - 1; > + accum_act_w = accum_hbp + mode->hdisplay; > + accum_act_h = accum_vbp + mode->vdisplay; > + total_width = mode->htotal - 1; > + total_height = mode->vtotal - 1; > > /* Configures the HS, VS, DE and PC polarities. Default Active Low */ > val = 0; > > - if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH) > + if (mode->flags & DRM_MODE_FLAG_PHSYNC) > val |= GCR_HSPOL; > > - if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) > + if (mode->flags & DRM_MODE_FLAG_PVSYNC) > val |= GCR_VSPOL; > > if (bus_flags & DRM_BUS_FLAG_DE_LOW) >