All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omapdrm: Remove outdated comment
Date: Thu, 15 Jul 2021 10:13:09 +0200	[thread overview]
Message-ID: <695f4a61-ef43-c08d-41d2-992059791cb8@suse.de> (raw)
In-Reply-To: <20210706073125.7689-1-tzimmermann@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 1426 bytes --]

ping for review

Am 06.07.21 um 09:31 schrieb Thomas Zimmermann:
> The comment refers to drm_irq_install() et al, which are not used by
> omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't
> be used any longer. Remove the comment.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/omapdrm/omap_irq.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c
> index bb6e3fc18204..4aca14dab927 100644
> --- a/drivers/gpu/drm/omapdrm/omap_irq.c
> +++ b/drivers/gpu/drm/omapdrm/omap_irq.c
> @@ -253,13 +253,6 @@ static const u32 omap_underflow_irqs[] = {
>   	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
>   };
> 
> -/*
> - * We need a special version, instead of just using drm_irq_install(),
> - * because we need to register the irq via omapdss.  Once omapdss and
> - * omapdrm are merged together we can assign the dispc hwmod data to
> - * ourselves and drop these and just use drm_irq_{install,uninstall}()
> - */
> -
>   int omap_drm_irq_install(struct drm_device *dev)
>   {
>   	struct omap_drm_private *priv = dev->dev_private;
> --
> 2.32.0
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2021-07-15  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  7:31 [PATCH] drm/omapdrm: Remove outdated comment Thomas Zimmermann
2021-07-15  8:13 ` Thomas Zimmermann [this message]
2021-07-15  8:48   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=695f4a61-ef43-c08d-41d2-992059791cb8@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tomba@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.