From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Dave Chinner <david@fromorbit.com>,
viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org
Subject: Re: [regression, v6.0-rc0, io-uring?] filesystem freeze hangs on sb_wait_write()
Date: Mon, 10 Oct 2022 20:01:51 -0600 [thread overview]
Message-ID: <697611c3-04b0-e8ea-d43d-d05b7c334814@kernel.dk> (raw)
In-Reply-To: <8e45c8ee-fe38-75a9-04f4-cfa2d54baf88@gmail.com>
On 10/10/22 7:10 PM, Pavel Begunkov wrote:
> On 10/11/22 01:40, Dave Chinner wrote:
> [...]
>> I note that there are changes to the the io_uring IO path and write
>> IO end accounting in the io_uring stack that was merged, and there
>> was no doubt about the success/failure of the reproducer at each
>> step. Hence I think the bisect is good, and the problem is someone
>> in the io-uring changes.
>>
>> Jens, over to you.
>>
>> The reproducer - generic/068 - is 100% reliable here, io_uring is
>> being exercised by fsstress in the background whilst the filesystem
>> is being frozen and thawed repeatedly. Some path in the io-uring
>> code has an unbalanced sb_start_write()/sb_end_write() pair by the
>> look of it....
>
> A quick guess, it's probably
>
> b000145e99078 ("io_uring/rw: defer fsnotify calls to task context")
>
> From a quick look, it removes kiocb_end_write() -> sb_end_write()
> from kiocb_done(), which is a kind of buffered rw completion path.
Yeah, I'll take a look.
Didn't get the original email, only Pavel's reply?
--
Jens Axboe
next prev parent reply other threads:[~2022-10-11 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 5:03 [regression, v6.0-rc0] filesystem freeze hangs on sb_wait_write() Dave Chinner
2022-10-11 0:40 ` [regression, v6.0-rc0, io-uring?] " Dave Chinner
2022-10-11 1:10 ` Pavel Begunkov
2022-10-11 2:01 ` Jens Axboe [this message]
2022-10-11 2:10 ` Pavel Begunkov
2022-10-11 2:54 ` Jens Axboe
2022-10-11 14:18 ` Jens Axboe
2022-10-11 14:39 ` Pavel Begunkov
2022-10-11 14:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697611c3-04b0-e8ea-d43d-d05b7c334814@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=david@fromorbit.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.