From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F47BC76188 for ; Fri, 19 Jul 2019 09:14:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9E97B2173B for ; Fri, 19 Jul 2019 09:14:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E97B2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34B112C2B; Fri, 19 Jul 2019 11:14:01 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7203F2BC7 for ; Fri, 19 Jul 2019 11:13:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 02:13:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,281,1559545200"; d="scan'208";a="173451333" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 19 Jul 2019 02:13:56 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 19 Jul 2019 02:13:56 -0700 Received: from HASMSX110.ger.corp.intel.com (10.184.198.28) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 19 Jul 2019 02:13:56 -0700 Received: from hasmsx107.ger.corp.intel.com ([169.254.2.129]) by HASMSX110.ger.corp.intel.com ([169.254.6.153]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 12:13:53 +0300 From: "Nowak, DamianX" To: Nithin Dabilpuram , Hyong Youb Kim , David Marchand , "Thomas Monjalon" , "Yigit, Ferruh" , "Burakov, Anatoly" CC: "jerinj@marvell.com" , John Daley , Shahed Shaikh , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/3] vfio: revert change that does intr eventfd setup at probe Thread-Index: AQHVPJcgDYKftLesGEygxcYklBLuwabRqMtg Date: Fri, 19 Jul 2019 09:13:52 +0000 Message-ID: <6976F642F4CB7B4C9D17DE41C99F326055D09700@hasmsx107.ger.corp.intel.com> References: <20190717115852.171416-1-ndabilpuram@marvell.com> <20190717115852.171416-2-ndabilpuram@marvell.com> In-Reply-To: <20190717115852.171416-2-ndabilpuram@marvell.com> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjE4NDM4ZDAtM2ViOC00ZDgwLWE1NzMtYWZlNThiZTA1YzQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicHl2WVpobnlTSWxjNXA4eHNaanlndWYzODIzckdldjJPeUFsVUU5TDlMMGgwd2NGOXVsaEx5SE16ZnBCV05WbSJ9 x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] vfio: revert change that does intr eventfd setup at probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 13:59 > To: Hyong Youb Kim ; David Marchand > ; Thomas Monjalon > ; Yigit, Ferruh ; Burakov, > Anatoly > Cc: jerinj@marvell.com; John Daley ; Shahed Shaikh > ; dev@dpdk.org; Nithin Dabilpuram > > Subject: [dpdk-dev] [PATCH 1/3] vfio: revert change that does intr eventf= d > setup at probe >=20 > This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4. > "vfio: fix interrupts race condition" >=20 > The above mentioned commit moves the interrupt's eventfd setup to probe > time but only enables one interrupt for all types of interrupt handles i.= e > VFIO_MSI, VFIO_LEGACY, VFIO_MSIX, UIO. > It works fine with default case but breaks below cases specifically for M= SIX > based interrupt handles. >=20 > * Applications like l3fwd-power that request rxq interrupts > while ethdev setup. > * Drivers that need > 1 MSIx interrupts to be configured for > functionality to work. >=20 > VFIO PCI for MSIx expects all the possible vectors to be setup up when us= ing > VFIO_IRQ_SET_ACTION_TRIGGER so that they can be allocated from kernel > pci subsystem. Only way to increase the number of vectors later is first = free > all by using VFIO_IRQ_SET_DATA_NONE with action trigger and then enable > new vector count. >=20 > Above commit changes the behavior of rte_intr_[enable|disable] to only > mask and unmask unlike earlier behavior and thereby breaking above two > scenarios. >=20 > Fixes: 89aac60e0be9 ("vfio: fix interrupts race condition") > Cc: david.marchand@redhat.com >=20 > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Jerin Jacob > --- > drivers/bus/pci/linux/pci_vfio.c | 78 ++++++------ > lib/librte_eal/linux/eal/eal_interrupts.c | 201 +++++++++++++++++++++++- > ------ I can confirm this patch fixes "EAL: error configuring interrupt" issue o= n my C6XX board Damian