From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DF0C433F5 for ; Thu, 28 Apr 2022 10:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233710AbiD1KHQ (ORCPT ); Thu, 28 Apr 2022 06:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233319AbiD1KGa (ORCPT ); Thu, 28 Apr 2022 06:06:30 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D4C3EF22 for ; Thu, 28 Apr 2022 02:54:51 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id r13so8478284ejd.5 for ; Thu, 28 Apr 2022 02:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DBbj9vS4RiFSbV5R5DxxG2khMbNBoKzLwuIctcI4Aas=; b=L9cmlONc//L5dCt/4+WU2nzhjMngUTJ6znb5nHNh7fjINXCLkHSu7CVBmuQyI2GWeQ munaiWap7dNmrg5VJHQVJD/fr++mtTu2Nzippq5fjCOPNglIZSC/3dhgQ6cQ/9xHzwHN jdNaJrRJk4XO682JIf4A9MFDhKSEhDBxCfwVZwqCEkd01/nLxS6dMT6Tg0/4mvQrgCGN 8Egovu+UaeilDMQggA7ecZMKVfBNlQ7Sf5NhRwbnj9d9TqV/65muAt3/aRYLbPAdM2pF uAcgXnhl0LvgCbhXruDxcaC4ApHSGjS0+BxjuJXR25lj3yLta4UouOgo7iZeytJxnhWM eN3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DBbj9vS4RiFSbV5R5DxxG2khMbNBoKzLwuIctcI4Aas=; b=OYXaLTGEQl6gP8cmUdkT/coIcHC5QJz5H2OlHQl3E4JYl5ypQ+Jom1XX/nP7jAQfG9 dSzuHa+npK5GlCdH6ToLUfv38ql/VdOSgtFeE3BY+ZwlWcCFdC5OL5TQT/MvGL7Wv80e lNBQZktz9YqI34L0SjP1wILFtMv790zRX3eNw/4HbsTzNS8Erw3Qj+TqFTqv9Q65jDRs 2plNoyoH3LNNnZtkcvzchOPQVCVHRrr8B1q7uq3VBZkFYGMqzx0ZeeIYy6GdpV6PQHg6 oj02x7AuUKSXTrD9YvwnrEaGDxAJVd/71vGaX93zw4gCtyDNQYwojjjBZ6j0kTp3VF0Z bSnQ== X-Gm-Message-State: AOAM533IsH792IPc/e+FsgS4aCHEKEkpJdlv+ek2MTHZBKMALK5MrBqo 21xql3aBwsBoGTL/h6GtxM0KGA== X-Google-Smtp-Source: ABdhPJzUDZjZ6FqfqR9CbNRRWJcRTyZXYsJlcIWLhXC9v0jQj+VsOYGcUY63+9v8dDPDpntyVJYgcQ== X-Received: by 2002:a17:906:5d15:b0:6f3:77e6:2126 with SMTP id g21-20020a1709065d1500b006f377e62126mr23304886ejt.707.1651139690020; Thu, 28 Apr 2022 02:54:50 -0700 (PDT) Received: from [192.168.0.161] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 22-20020a17090600d600b006dfbc46efabsm8125774eji.126.2022.04.28.02.54.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 02:54:49 -0700 (PDT) Message-ID: <6981f93a-ef01-6ba0-4451-26526372d666@linaro.org> Date: Thu, 28 Apr 2022 11:54:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 08/10] ARM: dts: exynos: use proper 'dma-channels/requests' properties Content-Language: en-US To: Marek Szyprowski , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-9-krzysztof.kozlowski@linaro.org> <5eeac2a0-4293-675e-9dc2-25ed8ab3fb8f@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <5eeac2a0-4293-675e-9dc2-25ed8ab3fb8f@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2022 11:50, Marek Szyprowski wrote: > Hi Krzysztof, > > On 27.04.2022 17:58, Krzysztof Kozlowski wrote: >> pl330 DMA controller bindings documented 'dma-channels' and >> 'dma-requests' properties (without leading hash sign), so fix the DTS to >> match the bindings. >> >> Reported-by: Rob Herring >> Signed-off-by: Krzysztof Kozlowski > > Are those properties really needed for PL330 driver on Exynos SoCs? I've > removed them and I still see the proper values read from registers and > reported in the log (Exynos4210): > > dma-pl330 12680000.dma-controller: Loaded driver for PL330 DMAC-141330 > dma-pl330 12680000.dma-controller:       DBUFF-32x4bytes Num_Chans-8 > Num_Peri-32 Num_Events-32 > dma-pl330 12690000.dma-controller: Loaded driver for PL330 DMAC-141330 > dma-pl330 12690000.dma-controller:       DBUFF-32x4bytes Num_Chans-8 > Num_Peri-32 Num_Events-32 > dma-pl330 12850000.dma-controller: Loaded driver for PL330 DMAC-141330 > dma-pl330 12850000.dma-controller:       DBUFF-64x8bytes Num_Chans-8 > Num_Peri-1 Num_Events-32 > > I also don't see any code that would read those properties. IMHO they > should be simply removed at all, at least for the PL330 related nodes. In current Linux implementation they indeed are not used. Nothing parses them. However: 1. They describe (hopefully correct) the hardware. 2. They might be used by other implementations of pl330 driver. I would not remove them from existing sources, but indeed maybe there is no need to add for new files. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68585C433EF for ; Thu, 28 Apr 2022 10:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xtzAQIUVnqff0wApWtJZL2MBWRXNMnj5LTmVFl7DcoI=; b=vTOMoA6Yx6PBpd Vv3U+6JRevzS044gqGaRXbGR7O21g7Nk1dwRB+KD7cyivu0y71oOsLGLTgfpPoa+kXtTJKVu9DUfR /hQB1rZEfKwjHiSNyygM0X9E75HR0E3ZsETDodQN0dljeQapUo2zP1ZVWQPElPbw7dZqSd3ATG3Zf 9P3TMTRs8LDbYpy7WiD0UqoyISQMGhnfYzJzmsaIDxFxlhFycGRRHp6lvGOv7a727EbppvLfc4pdq oPZwxSmDM6LV08o2um8wwFi4j3aby7I2oC23BK0gf23E+DntrEmhxTSM1TuWCfoig0G1kI8B/x43Q X8NsQKBK+MEv1X5zMKKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk10A-005xad-TE; Thu, 28 Apr 2022 10:03:59 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk0rN-005tf2-9M for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 09:54:56 +0000 Received: by mail-ej1-x62b.google.com with SMTP id l18so8452408ejc.7 for ; Thu, 28 Apr 2022 02:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DBbj9vS4RiFSbV5R5DxxG2khMbNBoKzLwuIctcI4Aas=; b=L9cmlONc//L5dCt/4+WU2nzhjMngUTJ6znb5nHNh7fjINXCLkHSu7CVBmuQyI2GWeQ munaiWap7dNmrg5VJHQVJD/fr++mtTu2Nzippq5fjCOPNglIZSC/3dhgQ6cQ/9xHzwHN jdNaJrRJk4XO682JIf4A9MFDhKSEhDBxCfwVZwqCEkd01/nLxS6dMT6Tg0/4mvQrgCGN 8Egovu+UaeilDMQggA7ecZMKVfBNlQ7Sf5NhRwbnj9d9TqV/65muAt3/aRYLbPAdM2pF uAcgXnhl0LvgCbhXruDxcaC4ApHSGjS0+BxjuJXR25lj3yLta4UouOgo7iZeytJxnhWM eN3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DBbj9vS4RiFSbV5R5DxxG2khMbNBoKzLwuIctcI4Aas=; b=aUuU7GJbcZa0Uw1H1B1vS0r5t0ZbIGz0nrRkMdtKb9O2oPBMw6hsBfg5ctrkFw4v45 Crt9N9fGOWyOd/zpcMovJkUH8bD7h+a+7sU1DlxGKLDRc1+BtMtugc0FEM4IiM4ot531 RET4LOmyUd4f6J+ecfdq5+TQu/9Mxpjp07/v/fYn9KjOtxwn8eWB1o8s0qOt7LkgbGFn rfeESGUgWVOkF2ZZLshdZ/VxDrWocwjcGKvMNI07NcY68d5TwNxkmdJOfwEH/awobDFo zqLluXuI2dJzTjOwKAvIWvx/7lSgtCTc3Z35GN5A4h/TKEUwQwCV5ATuWPOyMP+2bfSo Wsbg== X-Gm-Message-State: AOAM530GgrqLeR4BUeUzx6QvFzzZsYm6Urb/QuAYR1Wve0jCKzQc16yr XMCLRxKYr4Vn9rcZ5kHS4thyhg== X-Google-Smtp-Source: ABdhPJzUDZjZ6FqfqR9CbNRRWJcRTyZXYsJlcIWLhXC9v0jQj+VsOYGcUY63+9v8dDPDpntyVJYgcQ== X-Received: by 2002:a17:906:5d15:b0:6f3:77e6:2126 with SMTP id g21-20020a1709065d1500b006f377e62126mr23304886ejt.707.1651139690020; Thu, 28 Apr 2022 02:54:50 -0700 (PDT) Received: from [192.168.0.161] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 22-20020a17090600d600b006dfbc46efabsm8125774eji.126.2022.04.28.02.54.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 02:54:49 -0700 (PDT) Message-ID: <6981f93a-ef01-6ba0-4451-26526372d666@linaro.org> Date: Thu, 28 Apr 2022 11:54:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 08/10] ARM: dts: exynos: use proper 'dma-channels/requests' properties Content-Language: en-US To: Marek Szyprowski , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-9-krzysztof.kozlowski@linaro.org> <5eeac2a0-4293-675e-9dc2-25ed8ab3fb8f@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <5eeac2a0-4293-675e-9dc2-25ed8ab3fb8f@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_025453_382444_4B64BD8A X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjgvMDQvMjAyMiAxMTo1MCwgTWFyZWsgU3p5cHJvd3NraSB3cm90ZToKPiBIaSBLcnp5c3p0 b2YsCj4gCj4gT24gMjcuMDQuMjAyMiAxNzo1OCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK Pj4gcGwzMzAgRE1BIGNvbnRyb2xsZXIgYmluZGluZ3MgZG9jdW1lbnRlZCAnZG1hLWNoYW5uZWxz JyBhbmQKPj4gJ2RtYS1yZXF1ZXN0cycgcHJvcGVydGllcyAod2l0aG91dCBsZWFkaW5nIGhhc2gg c2lnbiksIHNvIGZpeCB0aGUgRFRTIHRvCj4+IG1hdGNoIHRoZSBiaW5kaW5ncy4KPj4KPj4gUmVw b3J0ZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4+IFNpZ25lZC1vZmYtYnk6 IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4KPiAK PiBBcmUgdGhvc2UgcHJvcGVydGllcyByZWFsbHkgbmVlZGVkIGZvciBQTDMzMCBkcml2ZXIgb24g RXh5bm9zIFNvQ3M/IEkndmUgCj4gcmVtb3ZlZCB0aGVtIGFuZCBJIHN0aWxsIHNlZSB0aGUgcHJv cGVyIHZhbHVlcyByZWFkIGZyb20gcmVnaXN0ZXJzIGFuZCAKPiByZXBvcnRlZCBpbiB0aGUgbG9n IChFeHlub3M0MjEwKToKPiAKPiBkbWEtcGwzMzAgMTI2ODAwMDAuZG1hLWNvbnRyb2xsZXI6IExv YWRlZCBkcml2ZXIgZm9yIFBMMzMwIERNQUMtMTQxMzMwCj4gZG1hLXBsMzMwIDEyNjgwMDAwLmRt YS1jb250cm9sbGVyOsKgwqDCoMKgwqDCoCBEQlVGRi0zMng0Ynl0ZXMgTnVtX0NoYW5zLTggCj4g TnVtX1BlcmktMzIgTnVtX0V2ZW50cy0zMgo+IGRtYS1wbDMzMCAxMjY5MDAwMC5kbWEtY29udHJv bGxlcjogTG9hZGVkIGRyaXZlciBmb3IgUEwzMzAgRE1BQy0xNDEzMzAKPiBkbWEtcGwzMzAgMTI2 OTAwMDAuZG1hLWNvbnRyb2xsZXI6wqDCoMKgwqDCoMKgIERCVUZGLTMyeDRieXRlcyBOdW1fQ2hh bnMtOCAKPiBOdW1fUGVyaS0zMiBOdW1fRXZlbnRzLTMyCj4gZG1hLXBsMzMwIDEyODUwMDAwLmRt YS1jb250cm9sbGVyOiBMb2FkZWQgZHJpdmVyIGZvciBQTDMzMCBETUFDLTE0MTMzMAo+IGRtYS1w bDMzMCAxMjg1MDAwMC5kbWEtY29udHJvbGxlcjrCoMKgwqDCoMKgwqAgREJVRkYtNjR4OGJ5dGVz IE51bV9DaGFucy04IAo+IE51bV9QZXJpLTEgTnVtX0V2ZW50cy0zMgo+IAo+IEkgYWxzbyBkb24n dCBzZWUgYW55IGNvZGUgdGhhdCB3b3VsZCByZWFkIHRob3NlIHByb3BlcnRpZXMuIElNSE8gdGhl eSAKPiBzaG91bGQgYmUgc2ltcGx5IHJlbW92ZWQgYXQgYWxsLCBhdCBsZWFzdCBmb3IgdGhlIFBM MzMwIHJlbGF0ZWQgbm9kZXMuCgpJbiBjdXJyZW50IExpbnV4IGltcGxlbWVudGF0aW9uIHRoZXkg aW5kZWVkIGFyZSBub3QgdXNlZC4gTm90aGluZyBwYXJzZXMKdGhlbS4gSG93ZXZlcjoKMS4gVGhl eSBkZXNjcmliZSAoaG9wZWZ1bGx5IGNvcnJlY3QpIHRoZSBoYXJkd2FyZS4KMi4gVGhleSBtaWdo dCBiZSB1c2VkIGJ5IG90aGVyIGltcGxlbWVudGF0aW9ucyBvZiBwbDMzMCBkcml2ZXIuCgpJIHdv dWxkIG5vdCByZW1vdmUgdGhlbSBmcm9tIGV4aXN0aW5nIHNvdXJjZXMsIGJ1dCBpbmRlZWQgbWF5 YmUgdGhlcmUgaXMKbm8gbmVlZCB0byBhZGQgZm9yIG5ldyBmaWxlcy4KCkJlc3QgcmVnYXJkcywK S3J6eXN6dG9mCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==