From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE148C433E6 for ; Wed, 3 Feb 2021 00:44:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 785EF64F72 for ; Wed, 3 Feb 2021 00:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233179AbhBCAoW (ORCPT ); Tue, 2 Feb 2021 19:44:22 -0500 Received: from mga07.intel.com ([134.134.136.100]:57323 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233127AbhBCAoT (ORCPT ); Tue, 2 Feb 2021 19:44:19 -0500 IronPort-SDR: A3b2UJzlBC79VhudCtAeNq/wXYCx7+qBTZjbftKv98QWbYr/ZVTe1yJ1jRwsE5GtOWLIxBhrt0 Qf9tYs7vBM1Q== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="245036883" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="245036883" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 16:42:23 -0800 IronPort-SDR: MMKNBch+1mmOdmWJTo+x57VCujaG3b48l/M96+PWoodyq4a31cr3LEkCDmFuMiT5MNDd7vIzh7 hekzoLknfkfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="406362278" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2021 16:42:22 -0800 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, Yian Chen , Ashok Raj , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] iommu/vt-d: Apply SATC policy To: Joerg Roedel References: <20210202044057.615277-1-baolu.lu@linux.intel.com> <20210202044057.615277-4-baolu.lu@linux.intel.com> <20210202135501.GX32671@8bytes.org> From: Lu Baolu Message-ID: <698a0a53-d0f4-cee2-03d7-4e914276737e@linux.intel.com> Date: Wed, 3 Feb 2021 08:33:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210202135501.GX32671@8bytes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/21 9:55 PM, Joerg Roedel wrote: > On Tue, Feb 02, 2021 at 12:40:57PM +0800, Lu Baolu wrote: >> + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { >> + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); >> + if (satc->segment == pci_domain_nr(dev->bus) && satcu->atc_required) { > > You can safe a level of indentation and make this look nicer if you do: > > if (satc->segment != pci_domain_nr(dev->bus) || !satcu->atc_required) > continue; > > Yes. Thanks! Best regards, baolu >> + for_each_dev_scope(satcu->devices, satcu->devices_cnt, i, tmp) >> + if (to_pci_dev(tmp) == dev) >> + goto out; >> + } >> + } >> + ret = 0; >> +out: >> + rcu_read_unlock(); >> + return ret; >> +} From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28481C433E0 for ; Wed, 3 Feb 2021 00:42:27 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA56A64F6C for ; Wed, 3 Feb 2021 00:42:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA56A64F6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7A89685EC6; Wed, 3 Feb 2021 00:42:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vycVTmY7cMBy; Wed, 3 Feb 2021 00:42:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id EED6F85A00; Wed, 3 Feb 2021 00:42:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E149CC0FA7; Wed, 3 Feb 2021 00:42:25 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5A449C013A for ; Wed, 3 Feb 2021 00:42:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 41058204C3 for ; Wed, 3 Feb 2021 00:42:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kpcvlfOa4zFX for ; Wed, 3 Feb 2021 00:42:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by silver.osuosl.org (Postfix) with ESMTPS id E3619203CF for ; Wed, 3 Feb 2021 00:42:23 +0000 (UTC) IronPort-SDR: L/P4xJNM1OcFBlr70STk+4MSZJwYnEEwnccjjTwJ1rKfI6TQ0kJfTTiquSgm7+NRXwWWfgv9k0 bDTh6nB7UwNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="199900227" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="199900227" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 16:42:23 -0800 IronPort-SDR: MMKNBch+1mmOdmWJTo+x57VCujaG3b48l/M96+PWoodyq4a31cr3LEkCDmFuMiT5MNDd7vIzh7 hekzoLknfkfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="406362278" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2021 16:42:22 -0800 Subject: Re: [PATCH 3/3] iommu/vt-d: Apply SATC policy To: Joerg Roedel References: <20210202044057.615277-1-baolu.lu@linux.intel.com> <20210202044057.615277-4-baolu.lu@linux.intel.com> <20210202135501.GX32671@8bytes.org> From: Lu Baolu Message-ID: <698a0a53-d0f4-cee2-03d7-4e914276737e@linux.intel.com> Date: Wed, 3 Feb 2021 08:33:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210202135501.GX32671@8bytes.org> Content-Language: en-US Cc: iommu@lists.linux-foundation.org, Ashok Raj , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2/2/21 9:55 PM, Joerg Roedel wrote: > On Tue, Feb 02, 2021 at 12:40:57PM +0800, Lu Baolu wrote: >> + list_for_each_entry_rcu(satcu, &dmar_satc_units, list) { >> + satc = container_of(satcu->hdr, struct acpi_dmar_satc, header); >> + if (satc->segment == pci_domain_nr(dev->bus) && satcu->atc_required) { > > You can safe a level of indentation and make this look nicer if you do: > > if (satc->segment != pci_domain_nr(dev->bus) || !satcu->atc_required) > continue; > > Yes. Thanks! Best regards, baolu >> + for_each_dev_scope(satcu->devices, satcu->devices_cnt, i, tmp) >> + if (to_pci_dev(tmp) == dev) >> + goto out; >> + } >> + } >> + ret = 0; >> +out: >> + rcu_read_unlock(); >> + return ret; >> +} _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu