From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F02BBC433F5 for ; Thu, 16 Dec 2021 08:45:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id C409BC36AE5; Thu, 16 Dec 2021 08:45:22 +0000 (UTC) Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 4DC7FC36AE2; Thu, 16 Dec 2021 08:45:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 4DC7FC36AE2 Authentication-Results: smtp.kernel.org; dmarc=none (p=none dis=none) header.from=norik.com Authentication-Results: smtp.kernel.org; spf=none smtp.mailfrom=norik.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version: Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3uCWttw4dMS56bfbOmnNG/N1QPhPOwZOcgZviHGmbT0=; b=Wvdn1V2D5DsdPO5khDtpxbu6ox IvvYdVADELouYbOEAhKuxWrSlzsC6tlZxWQGBKu2JQEAA6Xhe9opfW/BdZkFIhqoZ2IQr6/4dlis7 hl8ANYJfdIv8AQDMz3vxv8t7QNjjH6liNdwq2zDk5NVx7SXxNAISS2oWGqPt6C8otQC66L8dpmhY5 xjw5c4PpCZU2tnSBafCnQmfmXv12cGHF1c7G/M4iMHwHm0pYa8THe8l+6pcftbToBKQ6ysIHfwwBX /ooFfcOCz4Ji/tA0iTyCGygwPj6d6oDNjZQD3XT6UyaBEuuFHPyJcFkWl0BWYzZYJH7HR/XC9HxFD 005pAilg==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:46774 helo=[192.168.69.215]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mxmNw-00Gi92-K6; Thu, 16 Dec 2021 09:45:15 +0100 Subject: Re: [PATCH 1/4] dt-bindings: arm: fsl: add PHYTEC phyGATE Tauri i.MX6 ULL To: Rob Herring List-Id: Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, soc@kernel.org, kernel@pengutronix.de, shawnguo@kernel.org, leoyang.li@nxp.com, krzysztof.kozlowski@canonical.com, linux@rempel-privat.de, festevam@gmail.com, arnd@arndb.de, linux-imx@nxp.com, y.bas@phytec.de References: <20211201125327.3704500-1-andrej.picej@norik.com> <20211201125327.3704500-2-andrej.picej@norik.com> From: Andrej Picej Message-ID: <698c247b-ba61-765b-9572-9181d1e141b8@norik.com> Date: Thu, 16 Dec 2021 09:45:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: Hi Rob, On 13. 12. 21 20:15, Rob Herring wrote: > On Wed, Dec 01, 2021 at 01:53:24PM +0100, Andrej Picej wrote: >> Add devicetree bindings for phyGATE Tauri board with phyCORE-i.MX6 ULL. >> >> Signed-off-by: Andrej Picej >> --- >> Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index 0b595b26061f..9c37f22b6c61 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -602,6 +602,15 @@ properties: >> - const: phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL >> - const: fsl,imx6ull >> >> + - description: i.MX6ULL PHYTEC phyGATE-Tauri >> + items: >> + - enum: >> + - phytec,imx6ull-phygate-tauri-emmc >> + - phytec,imx6ull-phygate-tauri-nand >> + - const: phytec,imx6ull-phygate-tauri # PHYTEC phyGATE-Tauri with i.MX6 ULL > > Is there really a need for 2 compatibles here? Either > phytec,imx6ull-phygate-tauri is specific enough (as nand/emmc can be > described elsewhere) or you need > phytec,imx6ull-phygate-tauri-emmc/phytec,imx6ull-phygate-tauri-nand. sorry for late reply. Yes, I think we need both. We have two board types for Tauri, one with eMMC and the other with NAND. Depending on this the NAND or eMMC gets enabled. The same logic is already used with other PHYTEC boards (e.g. Segin and Mira). Or did you had something other in mind? > > >> + - const: phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL >> + - const: fsl,imx6ull >> + >> - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Modules >> items: >> - enum: >> -- >> 2.25.1 >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2892C433EF for ; Thu, 16 Dec 2021 08:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8NsjpTc9jMyYOx0XNKwQq+M2KMfaK1qaYdJpiJ00lSY=; b=eYnpr03Es7zUkbpzrlbvTa8i1F sIrnR/+Iq0Z6q58+8l7wj+S6vSb3QBRydONnTr3oQJ1fpM3RmDAWKy5xXJZGbL8WDNDHUswtD4IFA lV7FRk7xRL0sY4NPWbVjsOyeOJAgzCXnU849nuc42zgtV1lhwWF038cp4GQGH3DI+tZOAP1XHJAGV kXOdh0OkVnhgI9CCr6GtEMVDA83ZYGeVK8ErlC42EScWLK3DE30WN1gxl6mG2kemhUxURpUNEM3uK ZGVoDBy9AIrv5KItbSRAr/1IC3sQOnwGXXB59fs0o4dxpNDE7w/Obgqat0540cApEFk3WBycg2Ymn FRV/+VEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxmOF-004An0-IY; Thu, 16 Dec 2021 08:45:27 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxmOB-004AlC-0d for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 08:45:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version: Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3uCWttw4dMS56bfbOmnNG/N1QPhPOwZOcgZviHGmbT0=; b=Wvdn1V2D5DsdPO5khDtpxbu6ox IvvYdVADELouYbOEAhKuxWrSlzsC6tlZxWQGBKu2JQEAA6Xhe9opfW/BdZkFIhqoZ2IQr6/4dlis7 hl8ANYJfdIv8AQDMz3vxv8t7QNjjH6liNdwq2zDk5NVx7SXxNAISS2oWGqPt6C8otQC66L8dpmhY5 xjw5c4PpCZU2tnSBafCnQmfmXv12cGHF1c7G/M4iMHwHm0pYa8THe8l+6pcftbToBKQ6ysIHfwwBX /ooFfcOCz4Ji/tA0iTyCGygwPj6d6oDNjZQD3XT6UyaBEuuFHPyJcFkWl0BWYzZYJH7HR/XC9HxFD 005pAilg==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:46774 helo=[192.168.69.215]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mxmNw-00Gi92-K6; Thu, 16 Dec 2021 09:45:15 +0100 Subject: Re: [PATCH 1/4] dt-bindings: arm: fsl: add PHYTEC phyGATE Tauri i.MX6 ULL To: Rob Herring Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, soc@kernel.org, kernel@pengutronix.de, shawnguo@kernel.org, leoyang.li@nxp.com, krzysztof.kozlowski@canonical.com, linux@rempel-privat.de, festevam@gmail.com, arnd@arndb.de, linux-imx@nxp.com, y.bas@phytec.de References: <20211201125327.3704500-1-andrej.picej@norik.com> <20211201125327.3704500-2-andrej.picej@norik.com> From: Andrej Picej Message-ID: <698c247b-ba61-765b-9572-9181d1e141b8@norik.com> Date: Thu, 16 Dec 2021 09:45:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211216_004523_277763_97E661D6 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 13. 12. 21 20:15, Rob Herring wrote: > On Wed, Dec 01, 2021 at 01:53:24PM +0100, Andrej Picej wrote: >> Add devicetree bindings for phyGATE Tauri board with phyCORE-i.MX6 ULL. >> >> Signed-off-by: Andrej Picej >> --- >> Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index 0b595b26061f..9c37f22b6c61 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -602,6 +602,15 @@ properties: >> - const: phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL >> - const: fsl,imx6ull >> >> + - description: i.MX6ULL PHYTEC phyGATE-Tauri >> + items: >> + - enum: >> + - phytec,imx6ull-phygate-tauri-emmc >> + - phytec,imx6ull-phygate-tauri-nand >> + - const: phytec,imx6ull-phygate-tauri # PHYTEC phyGATE-Tauri with i.MX6 ULL > > Is there really a need for 2 compatibles here? Either > phytec,imx6ull-phygate-tauri is specific enough (as nand/emmc can be > described elsewhere) or you need > phytec,imx6ull-phygate-tauri-emmc/phytec,imx6ull-phygate-tauri-nand. sorry for late reply. Yes, I think we need both. We have two board types for Tauri, one with eMMC and the other with NAND. Depending on this the NAND or eMMC gets enabled. The same logic is already used with other PHYTEC boards (e.g. Segin and Mira). Or did you had something other in mind? > > >> + - const: phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL >> + - const: fsl,imx6ull >> + >> - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Modules >> items: >> - enum: >> -- >> 2.25.1 >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel