From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB7DC433F5 for ; Tue, 16 Nov 2021 18:03:37 +0000 (UTC) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by mx.groups.io with SMTP id smtpd.web12.182.1637085816440547960 for ; Tue, 16 Nov 2021 10:03:36 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: 0leil.net, ip: 217.70.183.201, mailfrom: foss@0leil.net) Received: (Authenticated sender: foss@0leil.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 106EF1BF212; Tue, 16 Nov 2021 18:03:32 +0000 (UTC) Date: Tue, 16 Nov 2021 19:03:29 +0100 From: Quentin Schulz To: Khem Raj , Quentin Schulz CC: Quentin Schulz , Trevor Woerner , Yocto-mailing-list Subject: =?US-ASCII?Q?Re=3A_=5Byocto=5D_=5Bmeta-rockchip=5D=5BPATC?= =?US-ASCII?Q?H=5D_kernel=3A_linux-yocto=3A_fix_broke?= =?US-ASCII?Q?n_Ethernet_MAC_controller_on_RK3?= =?US-ASCII?Q?399_on_5=2E14_=3E=3D_version_=3C=3D_5=2E14=2E11?= In-Reply-To: References: <20211116153256.3639663-1-quentin.schulz@theobroma-systems.com> <20211116170406.abau3j6liwsdonbp@fedora> <20211116171242.7dyycd3d2qwb4ske@fedora> Message-ID: <69C8168A-27F2-4B12-9592-264E80EFBC2D@0leil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 16 Nov 2021 18:03:37 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto/message/55351 On November 16, 2021 6:45:05 PM GMT+01:00, Khem Raj wrote: >On Tue, Nov 16, 2021 at 9:12 AM Quentin Schulz < >quentin=2Eschulz@theobroma-systems=2Ecom> wrote: > >> On Tue, Nov 16, 2021 at 09:08:41AM -0800, Khem Raj wrote: >> > On Tue, Nov 16, 2021 at 9:04 AM Quentin Schulz >> > wrote: >> > > >> > > On Tue, Nov 16, 2021 at 09:00:42AM -0800, Khem Raj wrote: >> > > > On Tue, Nov 16, 2021 at 7:52 AM Quentin Schulz >> > > > wrote: >> > > > > >> > > > > From Linux kernel v5=2E14 to v5=2E14=2E11 (both included), the = Ethernet >> MAC >> > > > > controller found on RK3399 is not working=2E >> > > > > >> > > > > A fix is available in v5=2E14=2E12 and later (available also in= v5=2E15) >> > > > > which is provided here and applied to linux-yocto source tree i= f >> > > > > linux-yocto version is of the impacted ones=2E >> > > > > >> > > > > The conditional patching is unfortunately required because >> Honister 3=2E4 >> > > > > has linux-yocto v5=2E14=2E9 and Honister 3=2E4=2E1 will have at= least >> > > > > linux-yocto v5=2E14=2E14=2E >> > > > >> > > > Patching piece below looks quite a bit=2E >> > > > lets just fix v5=2E14=2E14 and dont worry about 3=2E4 >> > > > >> > > >> > > v5=2E14=2E14 is already fixed=2E The only release currently is 3=2E= 4 and I hit >> > > that issue, hence the patch=2E >> > > I assume not everybody is updating to 3=2E4=2E1 when it's out, I've= seen >> > > people running behind dot releases=2E >> > > What's bothering you? >> > >> > once dot release is out then thats whats maintained not the original >> > release since they are incremental=2E >> > the anon python to apply a patch=2E Can you explain why we want to pa= tch >> > applied this way ? >> > >> >> I could define a python function and use it like this: >> SRC_URI:append:rk3399 =3D "${@rk3399_fix_mac(d)}" >> >> Would that work better for you? > > >I am not yet convinced why should we have such version specific patch > If you could explain what's *really* bothering you, I could try to find a = proper explanation or agree with you but it's a bit too vague to me right n= ow=2E Anyway, I'll do some guesses in the next paragraphs=2E Because Ethernet does not work for all RK3399-based boards in the latest a= nd only release of Honister? meta-rockchip is the BSP layer for Rockchip based devices, if not there, w= here should I put this patch? Or are we just going to say "Ethernet does not work, we know" to people as= king instead of having this patch in? Obviously you could tell them to upgr= ade their oe-core/poky git repo to rolling honister or 3=2E4=2E1 once it's = out but having this patch in avoid those questions=2E I understand we're talking about policy here=2E I am not fond of this patc= h either but Ethernet is quite critical on boards which don't have WiFi for= example=2E I don't have anything better to suggest to fix this in the *lat= est* release=2E Cheers Quentin >> >> >> Cheers, >> Quentin >>