From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9MvCdE9zzzeybH76zEmTt4IogcXntZop9TJWFV1yeqk=; b=C8fK/0g+9g/H0SH47XPvXmmujTWypRthlEcmSnbOXlVe0dTcw533Epco+ubx0jnqXp 8h4j9+F5fWBdipbkRuGjnwsHinVZFxIYz7Qeb/gFbceHJ5CEBXkG7MGVnL/ledMe6rC4 y2RacPYQ90o0JbF07+grEsY84lNt4eRz9ETnlAS6CXksmH28ZwarhxAjTwVZKQeJOI51 jMWZ6HQ0pLmB93p/9GeJg+eP1AHRr7cHmlTDthDfRse0ejlpNFIzaXinelEF5wEK7jY3 R90UVDr8MIfUrn/lS3+pOsMT59m+YLRlRi7KATj8Jo0Ubt2mkofceu+3lvGzqnp7E1fV xEMQ== Subject: Re: [PATCH] datastruct/hash: Tweak appearance of updated code in snippet References: <20181226150018.GY4170@linux.ibm.com> <20181231210307.GU4170@linux.ibm.com> <6ebd05a2-62be-478f-ab47-78862824072e@gmail.com> <20190101180025.GY4170@linux.ibm.com> <3fa9dcca-14d0-876d-fdcb-5db7eff3a97b@gmail.com> <20190102171848.GA4170@linux.ibm.com> <20190102191822.GA30360@linux.ibm.com> <20190103172145.GG4170@linux.ibm.com> From: Akira Yokosawa Message-ID: <69a2dffb-056c-29e3-fdfb-df61b705d416@gmail.com> Date: Fri, 4 Jan 2019 08:35:07 +0900 MIME-Version: 1.0 In-Reply-To: <20190103172145.GG4170@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: "Paul E. McKenney" Cc: perfbook@vger.kernel.org, Akira Yokosawa List-ID: On 2019/01/03 09:21:45 -0800, Paul E. McKenney wrote: > On Fri, Jan 04, 2019 at 12:57:06AM +0900, Akira Yokosawa wrote: >> >From ae50debbf06ad674e4941b55764b02c776484509 Mon Sep 17 00:00:00 2001 >> From: Akira Yokosawa >> Date: Fri, 4 Jan 2019 00:19:26 +0900 >> Subject: [PATCH] datastruct/hash: Tweak appearance of updated code in snippet >> >> Now that "[" and "]" are used within the code, "commandchars" should >> avoid them. >> >> Also wrap a line which has become too wide for the 2c layout. >> >> Signed-off-by: Akira Yokosawa > > Ah, the lsp[2] was a temporary state. I forgot to do a final "git push" > yesterday, apologies! > >> --- >> Hi Paul, >> >> I'm in the middle of reading the updated code. >> >> I'm sure you are working on the update of Section 10.4.2. >> Because of the code change, there are quite a few broken refs >> and duplicated labels at the moment. > > Yes, it is a bit of a mess at this point. I figured that if I was > going to have to modify the text and labels, I might as well do the > extra work to make the API a little less obnoxious. My first attempt to > move hash_resize.c's hashtab_add() in this direction broke very badly, > so it is back to the drawing board. > > I am thinking in terms of having a single struct ht_lock_state that > contains an array or two as one part of making the API less obnoxious, > which should help avoid the brokenness. > >> This commit just takes care of the vanishing "[" and "]" in >> Listing 10.11. > > I am hoping that we can retain "[" and "]" -- it is normally not such > a good idea to have arrays in parameter lists. > > Or do we need this commit anyway just due to array references within > the code snippet? Yes, we do. > If the latter, I will hand-apply the patch. Please do so. Thanks, Akira > >> Fixing labels is left for your update. > > Will do, and yes, they are a bit of a mess just now. ;-) > > Thanx, Paul > >> Thanks, Akira >> -- >> CodeSamples/datastruct/hash/hash_resize.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/CodeSamples/datastruct/hash/hash_resize.c b/CodeSamples/datastruct/hash/hash_resize.c >> index bb0a6f4..7392455 100644 >> --- a/CodeSamples/datastruct/hash/hash_resize.c >> +++ b/CodeSamples/datastruct/hash/hash_resize.c >> @@ -154,10 +154,11 @@ static void hashtab_unlock_lookup(struct hashtab *htp_master, void *key) >> rcu_read_unlock(); >> } >> >> -//\begin{snippet}[labelbase=ln:datastruct:hash_resize:lock_unlock_mod,commandchars=\\\[\]] >> +//\begin{snippet}[labelbase=ln:datastruct:hash_resize:lock_unlock_mod,commandchars=\\\@\$] >> /* Update-side lock/unlock functions. */ >> static void //\lnlbl{lock:b} >> -resize_lock_mod(struct hashtab *htp_master, void *key, struct ht_bucket *ls[2]) >> +resize_lock_mod(struct hashtab *htp_master, void *key, >> + struct ht_bucket *ls[2]) >> { >> long b; >> struct ht *htp; >> -- >> 2.7.4 >> >> >