From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118AbcIAJFA (ORCPT ); Thu, 1 Sep 2016 05:05:00 -0400 Received: from foss.arm.com ([217.140.101.70]:52210 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbcIAJE4 (ORCPT ); Thu, 1 Sep 2016 05:04:56 -0400 Subject: Re: [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm PMU To: Mathieu Poirier References: <1472573965-3881-1-git-send-email-mathieu.poirier@linaro.org> <1472573965-3881-6-git-send-email-mathieu.poirier@linaro.org> <94a6e940-cce8-a179-fe0c-c69a543e302c@arm.com> Cc: Arnaldo Carvalho de Melo , Arnaldo Carvalho de Melo , Peter Zijlstra , jolsa@kernel.org, Ingo Molnar , Alexander Shishkin , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" From: Suzuki K Poulose Message-ID: <69b45eb1-6b4b-329d-c833-5846f222119e@arm.com> Date: Thu, 1 Sep 2016 10:04:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/08/16 15:14, Mathieu Poirier wrote: > On 31 August 2016 at 03:37, Suzuki K Poulose wrote: >> On 30/08/16 17:19, Mathieu Poirier wrote: >>> >>> Using the PMU::set_drv_config() callback to enable the CoreSight >>> sink that will be used for the trace session. >> >> >>> +int cs_etm_set_drv_config(struct perf_evsel_config_term *term) >>> +{ >>> + int ret; >>> + char enable_sink[ENABLE_SINK_MAX]; >>> + >>> + snprintf(enable_sink, ENABLE_SINK_MAX, "%s/%s", >>> + term->val.drv_cfg, "enable_sink"); >>> + >>> + ret = cs_device__print_file(enable_sink, "%d", 1); >>> + if (ret < 0) >>> + return ret; >>> + >>> + return 0; >>> +} >> >> >> >> Don't we have to disable the sink at the end of the session ? How is that >> taken care of ? Did I miss that ? >> > > Correct - the sink has to be disabled once it is no longer needed. It > is a little tricky to do and I haven't decided on the best way to > proceed. Fortunately that aspect doesn't affect this patchset. Well, this patchset when used, could leave a sink enabled. If we a choose a different sink (say an ETF) from the perf, which occurs before the previous sink (say an ETR) in the coresight path, the perf wouldn't get any trace data, without any clue. May be we could register an atexit() handler for clearing the sink ? So that it is guaranteed to clear it irrespective of the path taken by perf to exit ? Cheers Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki.Poulose@arm.com (Suzuki K Poulose) Date: Thu, 1 Sep 2016 10:04:48 +0100 Subject: [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm PMU In-Reply-To: References: <1472573965-3881-1-git-send-email-mathieu.poirier@linaro.org> <1472573965-3881-6-git-send-email-mathieu.poirier@linaro.org> <94a6e940-cce8-a179-fe0c-c69a543e302c@arm.com> Message-ID: <69b45eb1-6b4b-329d-c833-5846f222119e@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 31/08/16 15:14, Mathieu Poirier wrote: > On 31 August 2016 at 03:37, Suzuki K Poulose wrote: >> On 30/08/16 17:19, Mathieu Poirier wrote: >>> >>> Using the PMU::set_drv_config() callback to enable the CoreSight >>> sink that will be used for the trace session. >> >> >>> +int cs_etm_set_drv_config(struct perf_evsel_config_term *term) >>> +{ >>> + int ret; >>> + char enable_sink[ENABLE_SINK_MAX]; >>> + >>> + snprintf(enable_sink, ENABLE_SINK_MAX, "%s/%s", >>> + term->val.drv_cfg, "enable_sink"); >>> + >>> + ret = cs_device__print_file(enable_sink, "%d", 1); >>> + if (ret < 0) >>> + return ret; >>> + >>> + return 0; >>> +} >> >> >> >> Don't we have to disable the sink at the end of the session ? How is that >> taken care of ? Did I miss that ? >> > > Correct - the sink has to be disabled once it is no longer needed. It > is a little tricky to do and I haven't decided on the best way to > proceed. Fortunately that aspect doesn't affect this patchset. Well, this patchset when used, could leave a sink enabled. If we a choose a different sink (say an ETF) from the perf, which occurs before the previous sink (say an ETR) in the coresight path, the perf wouldn't get any trace data, without any clue. May be we could register an atexit() handler for clearing the sink ? So that it is guaranteed to clear it irrespective of the path taken by perf to exit ? Cheers Suzuki