From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3EC4C43331 for ; Mon, 11 Nov 2019 12:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D05ED2190F for ; Mon, 11 Nov 2019 12:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfKKM4i (ORCPT ); Mon, 11 Nov 2019 07:56:38 -0500 Received: from www62.your-server.de ([213.133.104.62]:45840 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfKKM4i (ORCPT ); Mon, 11 Nov 2019 07:56:38 -0500 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iU9FA-0002XV-AI; Mon, 11 Nov 2019 13:56:32 +0100 Received: from [2a02:1205:507e:bf80:bef8:7f66:49c8:72e5] (helo=pc-11.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1iU9F9-000Mr8-W2; Mon, 11 Nov 2019 13:56:32 +0100 Subject: Re: Fw: [Bug 205469] New: x86_32: bpf: multiple test_bpf failures using eBPF JIT To: Wang YanQing Cc: Stephen Hemminger , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , bpf@vger.kernel.org References: <20191108075711.115a5f94@hermes.lan> <08b98fbd-f295-3a94-8b3e-70790179290c@iogearbox.net> <20191109183602.GA1033@udknight> From: Daniel Borkmann Message-ID: <69c1fa5e-7385-fe8d-ac17-42d22db84cf4@iogearbox.net> Date: Mon, 11 Nov 2019 13:56:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191109183602.GA1033@udknight> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25630/Mon Nov 11 10:59:49 2019) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 11/9/19 7:36 PM, Wang YanQing wrote: > On Sat, Nov 09, 2019 at 12:37:49AM +0100, Daniel Borkmann wrote: >> [ Cc Wang (x86_32 BPF JIT maintainer) ] >> >> On 11/8/19 4:57 PM, Stephen Hemminger wrote: >>> >>> Begin forwarded message: >>> >>> Date: Fri, 08 Nov 2019 07:35:59 +0000 >>> From: bugzilla-daemon@bugzilla.kernel.org >>> To: stephen@networkplumber.org >>> Subject: [Bug 205469] New: x86_32: bpf: multiple test_bpf failures using eBPF JIT >>> >>> >>> https://bugzilla.kernel.org/show_bug.cgi?id=205469 >>> >>> Bug ID: 205469 >>> Summary: x86_32: bpf: multiple test_bpf failures using eBPF JIT >>> Product: Networking >>> Version: 2.5 >>> Kernel Version: 4.19.81 LTS >>> Hardware: i386 >>> OS: Linux >>> Tree: Mainline >>> Status: NEW >>> Severity: normal >>> Priority: P1 >>> Component: Other >>> Assignee: stephen@networkplumber.org >>> Reporter: itugrok@yahoo.com >>> CC: itugrok@yahoo.com >>> Regression: No >>> >>> Created attachment 285829 >>> --> https://bugzilla.kernel.org/attachment.cgi?id=285829&action=edit >>> test_bpf failures: kernel 4.19.81/x86_32 (OpenWrt) >>> >>> Summary: >>> ======== >>> >>> Running the 4.19.81 LTS kernel on QEMU/x86_32, the standard test_bpf.ko >>> testsuite generates multiple errors with the eBPF JIT enabled: >>> >>> ... >>> test_bpf: #32 JSET jited:1 40 ret 0 != 20 46 FAIL >>> test_bpf: #321 LD_IND word positive offset jited:1 ret 0 != -291897430 FAIL >>> test_bpf: #322 LD_IND word negative offset jited:1 ret 0 != -1437222042 FAIL >>> test_bpf: #323 LD_IND word unaligned (addr & 3 == 2) jited:1 ret 0 != >>> -1150890889 FAIL >>> test_bpf: #326 LD_IND word positive offset, all ff jited:1 ret 0 != -1 FAIL >>> ... >>> test_bpf: Summary: 373 PASSED, 5 FAILED, [344/366 JIT'ed] >>> >>> However, with eBPF JIT disabled (net.core.bpf_jit_enable=0) all tests pass. >>> >>> >>> Steps to Reproduce: >>> =================== >>> >>> # sysctl net.core.bpf_jit_enable=1 >>> # modprobe test_bpf >>> >>> >>> >>> Affected Systems Tested: >>> ======================== >>> >>> OpenWrt master on QEMU/pc-q35(x86_32) [LTS kernel 4.19.81] >>> >>> >>> Kernel Logs: >>> ============ >>> >>> Boot log with test results is attached. >>> > > Hi Daniel Borkmann! > > I have tested and verified that the report bug has been fixed by commit > 711aef1bbf88 ("bpf, x32: Fix bug for BPF_JMP | {BPF_JSGT, BPF_JSLE, BPF_JSLT, BPF_JSGE}") > > But that fix hasn't been backport to stable trees, so maybe we should do it:) Yes, given you have access to a x32 setup and are also able to runtime test the backported JIT changes, please submit it to stable with us in Cc. Thanks Wang! Best, Daniel