From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 11 May 2017 13:47:09 +0200 Subject: [U-Boot] [RFC] drivers: pci: imx: add imx_pcie_remove function In-Reply-To: References: <1494434600-24661-1-git-send-email-tharvey@gateworks.com> <20170511090117.GA25159@collabora.com> Message-ID: <69dce8ed-f1e0-aca8-8902-54735599f8ad@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/11/2017 01:06 PM, Fabio Estevam wrote: > On Thu, May 11, 2017 at 6:01 AM, Peter Senna Tschudin > wrote: > >> Thank you for working on this! Your patch worked for me, but I needed to >> add an "extern void imx_pcie_remove(void);" before calling the function, >> which probably means I'm missing something. > > The extern should be added into a header file. > >> After applying this patch to u-boot, u-boot can initialize PCI and >> 4.11.0-next-20170510 will boot. Without your patch 4.11.0-next-20170510 >> do not boot if u-boot initialize the PCI bus. >> >> Thanks a lot! >> >> Here is the patch I'm using for our board: > > Stefano, > > The patches that Tim/Peter posted solve a kernel hang with kernel 4.11 > on mx6q when U-Boot has PCI support. > > Could you please take a look and let us know if there is a more > generic way to fix this issue, like fixing it for all mx6qdl boards > that have PCI support? > > I understand that ideally the imx6 pci driver should be converted to > driver model and then we add the .remove hook, like Lucas did for > Barebox: > https://git.pengutronix.de/cgit/barebox/commit/?id=f1da98da2760c21487bbba8f7fb957c843a22896 > > While the imx pci driver is not converted to device model, would you > be willing to accept such per board patches for the time being? The DM conversion should be pretty trivial IMO, no ? -- Best regards, Marek Vasut