From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C75C19F2A for ; Sun, 7 Aug 2022 08:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbiHGINV (ORCPT ); Sun, 7 Aug 2022 04:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiHGINT (ORCPT ); Sun, 7 Aug 2022 04:13:19 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE4A7658E for ; Sun, 7 Aug 2022 01:13:16 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id j1so7738419wrw.1 for ; Sun, 07 Aug 2022 01:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=tmFUfNh4QVWf7FV8JQO2RKCgPx5VNgT+zHlqt4Xmqxs=; b=Wy9WVbtviABX125m8AEBinwUx07M4uBXmvXD+wXutiO3gtwpCQioeNgkQ3lDr6f342 nITZw3dJHsR7EdYAGCgAesjXNT84m5WxufiTfQ0xC6My9pOKaf8IsaYbJInwRW7CqnlS mOSJji/OrXOCzev7z6SzEJ5qnK8QQmXfLY0pXIiqwXz9vFLnThotT8pF7s6DcsORHjVx HoSiK0DSj484PoWtSAaUL8MzPv02m0lvI4Xi5grOgnTAisXGkc1zmSNBb+aDfsSOrGPj TXajyF/XR2x3OQzI8bOdOKeoTmBYfLeIeENBwwbjyEMD9ImCukIFSTNDJCxASFoAV7Bs onew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=tmFUfNh4QVWf7FV8JQO2RKCgPx5VNgT+zHlqt4Xmqxs=; b=0sdeaIEtGzXHDo2pL6aITsYCedsu5RKb+ptIGQOXuI4cQXNQN79qbMLXlA0WO+A2w8 UYnUBwWvauStTZ7XGXCmBTM6BPKtkaWfFTVY7Sux9klInormqMQaivTCKXEhfDELqpuB lQhEvlZfxgRU9vi0N06Ywf9TSC3ytStKgoKW0zJbfIOEozCTQAUFVhgam6tcwQbZ7LEG 56eyGvWcQAZaINTLbxB8LmmrMGUaun4dv6deuBfoeBwHuF+9lAMEfMZPHCEvcBKxtSJf MP/ErAZZKi+8F7lDlbaQqEphu4pZ6kvasDqHq6W6Awg/z3RbFsjknan0wP2gvDpoj+kO zfQA== X-Gm-Message-State: ACgBeo23OcqVTRKDsYyzgY7NiVakkkf7mlITYj6C2hhl2hXKU9KFJ54W SswunkLB4JaAqJmn+R+cpY0= X-Google-Smtp-Source: AA6agR7mS1bNs6ux+L0LbXROZxAak8T9QuNG+7DzwSbVO8l+pQOexVfDWYZeCtqrLgIWEZbpD4bkPw== X-Received: by 2002:adf:fbc7:0:b0:220:6004:18ca with SMTP id d7-20020adffbc7000000b00220600418camr8301142wrs.632.1659859995566; Sun, 07 Aug 2022 01:13:15 -0700 (PDT) Received: from [192.168.0.104] ([77.126.166.31]) by smtp.gmail.com with ESMTPSA id x17-20020adfec11000000b0021ee0e233d9sm8363152wrn.96.2022.08.07.01.13.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Aug 2022 01:13:15 -0700 (PDT) Message-ID: <69f24a98-bd59-a0b6-5ed2-332de03b2131@gmail.com> Date: Sun, 7 Aug 2022 11:13:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH main v2 2/3] macsec: add Extended Packet Number support Content-Language: en-US To: Emeel Hakim , David Ahern , Sabrina Dubroca Cc: "netdev@vger.kernel.org" , Raed Salem , Tariq Toukan References: <20220802061813.24082-1-ehakim@nvidia.com> <20220802061813.24082-2-ehakim@nvidia.com> <5798fe5b-8424-c650-aac0-5293e1d907b4@kernel.org> From: Tariq Toukan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/7/2022 10:01 AM, Emeel Hakim wrote: > > >> -----Original Message----- >> From: David Ahern >> Sent: Thursday, 4 August 2022 21:37 >> To: Sabrina Dubroca ; Emeel Hakim >> >> Cc: netdev@vger.kernel.org; Raed Salem ; Tariq Toukan >> >> Subject: Re: [PATCH main v2 2/3] macsec: add Extended Packet Number >> support >> >> External email: Use caution opening links or attachments >> >> >> On 8/4/22 10:48 AM, Sabrina Dubroca wrote: >>> Hi Emeel, >>> >>> 2022-08-02, 09:18:12 +0300, ehakim@nvidia.com wrote: >>>> diff --git a/include/uapi/linux/if_macsec.h >>>> b/include/uapi/linux/if_macsec.h index eee31cec..6edfea0a 100644 >>>> --- a/include/uapi/linux/if_macsec.h >>>> +++ b/include/uapi/linux/if_macsec.h >>>> @@ -22,6 +22,8 @@ >>>> >>>> #define MACSEC_KEYID_LEN 16 >>>> >>>> +#define MACSEC_SALT_LEN 12 >>> >>> That's not in the kernel's uapi file (probably was forgotten), I don't >>> think we can just add it here. >>> >> >> can't. uapi files are synched with kernel releases, so that change would >> disappear on the next sync. > > ACK, > I can see that we have this define in the kernel > (not in a uapi file but as part of include/net/macsec.h), if I want to use > such a define what is the process here? do I need to move the define in > the kernel to the uapi file? > Also, in such a case Would those patches get accepted using such a define > while the kernel change is not accepted yet? Emeel, Please complete the kernel changes and get them accepted first. If a define exists in the kernel and needs to be exposed to the user, just move it to the uapi file and make sure it's still visible to all kernel usages.