* PATCH [1/1] ipv4: Prevent malformed UFO fragments in ip_append_page
@ 2016-06-10 19:21 Steven Caron
2016-06-11 0:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steven Caron @ 2016-06-10 19:21 UTC (permalink / raw)
To: Hannes Frederic Sowa, Cong Wang
Cc: linux-kernel, Linux Kernel Network Developers, Steven Caron
As the ip fragment offset field counts 8-byte chunks, non-final ip
fragments must be multiples of 8 bytes of payload. Depending on
the mtu and ip option sizes, ip_append_page wasn't respecting this,
notably when running NFS under UDP.
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 124bf0a..21ec54e 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1239,7 +1239,7 @@ ssize_t ip_append_page(struct sock *sk, struct flowi4 *fl4, struct page *page,
if (skb->ip_summed != CHECKSUM_PARTIAL)
return -EOPNOTSUPP;
- skb_shinfo(skb)->gso_size = mtu - fragheaderlen;
+ skb_shinfo(skb)->gso_size = maxfraglen - fragheaderlen;
skb_shinfo(skb)->gso_type = SKB_GSO_UDP;
}
cork->length += size;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: PATCH [1/1] ipv4: Prevent malformed UFO fragments in ip_append_page
2016-06-10 19:21 PATCH [1/1] ipv4: Prevent malformed UFO fragments in ip_append_page Steven Caron
@ 2016-06-11 0:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-11 0:59 UTC (permalink / raw)
To: steven.caron; +Cc: hannes, xiyou.wangcong, linux-kernel, netdev
From: Steven Caron <steven.caron@genband.com>
Date: Fri, 10 Jun 2016 19:21:26 +0000
> As the ip fragment offset field counts 8-byte chunks, non-final ip
> fragments must be multiples of 8 bytes of payload. Depending on
> the mtu and ip option sizes, ip_append_page wasn't respecting this,
> notably when running NFS under UDP.
>
All patch submissions need a proper signoff.
Please resubmit this properly.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-11 0:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10 19:21 PATCH [1/1] ipv4: Prevent malformed UFO fragments in ip_append_page Steven Caron
2016-06-11 0:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.