From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH v3 1/7] lib/librte_ether: modify the
 structures for fdir new modes
Date: Fri, 23 Oct 2015 08:08:34 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909020A2122@shsmsx102.ccr.corp.intel.com>
References: <1443161125-1035-1-git-send-email-wenzhuo.lu@intel.com>
 <20151022125718.GB20740@bricha3-MOBL3>
 <6A0DE07E22DDAD4C9103DF62FEBC0909020A1EE3@shsmsx102.ccr.corp.intel.com>
 <2331686.veA1YA3sRZ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 01B4995CC
 for <dev@dpdk.org>; Fri, 23 Oct 2015 10:08:59 +0200 (CEST)
In-Reply-To: <2331686.veA1YA3sRZ@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, October 23, 2015 3:30 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the struc=
tures
> for fdir new modes
>=20
> 2015-10-23 01:22, Lu, Wenzhuo:
> > From: Richardson, Bruce
> > > >  union rte_eth_fdir_flow {
> > > > -	struct rte_eth_l2_flow     l2_flow;
> > > > -	struct rte_eth_udpv4_flow  udp4_flow;
> > > > -	struct rte_eth_tcpv4_flow  tcp4_flow;
> > > > -	struct rte_eth_sctpv4_flow sctp4_flow;
> > > > -	struct rte_eth_ipv4_flow   ip4_flow;
> > > > -	struct rte_eth_udpv6_flow  udp6_flow;
> > > > -	struct rte_eth_tcpv6_flow  tcp6_flow;
> > > > -	struct rte_eth_sctpv6_flow sctp6_flow;
> > > > -	struct rte_eth_ipv6_flow   ipv6_flow;
> > > > +	struct rte_eth_l2_flow         l2_flow;
> > > > +	struct rte_eth_udpv4_flow      udp4_flow;
> > > > +	struct rte_eth_tcpv4_flow      tcp4_flow;
> > > > +	struct rte_eth_sctpv4_flow     sctp4_flow;
> > > > +	struct rte_eth_ipv4_flow       ip4_flow;
> > > > +	struct rte_eth_udpv6_flow      udp6_flow;
> > > > +	struct rte_eth_tcpv6_flow      tcp6_flow;
> > > > +	struct rte_eth_sctpv6_flow     sctp6_flow;
> > > > +	struct rte_eth_ipv6_flow       ipv6_flow;
> > > > +	struct rte_eth_mac_vlan_flow   mac_vlan_flow;
> > > > +	struct rte_eth_tunnel_flow     tunnel_flow;
> > >
> > > Can you please minimize the whitespace changes here. It looks in the
> > > diff like you are replacing the entire set of entries, but on closer
> > > inspection it looks like you are just adding in two extra lines.
> > Using vi or other editing tools, we can see all this fields are
> > aligned. I think it's worth to keep it.
>=20
> Bruce means you should avoid changing lines only for alignment.
> It's not a big deal if mac_vlan_flow is not perfectly aligned.
> When cosmetic rework is really needed, it's better to do it in a separate
> patch.
OK. I'll change it.