From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lu, Wenzhuo" Subject: Re: [PATCH v2] ixgbe: Fix disable interrupt twice Date: Fri, 29 Jan 2016 08:07:05 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909034256DA@shsmsx102.ccr.corp.intel.com> References: <1454046700-20843-1-git-send-email-michael.qiu@intel.com> <1454047090-21274-1-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Qiu, Michael" , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2FA73C5D4 for ; Fri, 29 Jan 2016 09:07:09 +0100 (CET) In-Reply-To: <1454047090-21274-1-git-send-email-michael.qiu@intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Michael, > -----Original Message----- > From: Qiu, Michael > Sent: Friday, January 29, 2016 1:58 PM > To: dev@dpdk.org > Cc: Zhou, Danny; Liu, Yong; Liang, Cunming; Lu, Wenzhuo; Qiu, Michael > Subject: [PATCH v2] ixgbe: Fix disable interrupt twice >=20 > Currently, ixgbe vf and pf will disable interrupt twice in stop stage and= uninit > stage. It will cause an error: >=20 > testpmd> quit >=20 > Shutting down port 0... > Stopping ports... > Done > Closing ports... > EAL: Error disabling MSI-X interrupts for fd 26 > Done >=20 > Becasue the interrupt already been disabled in stop stage. > Since it is enabled in init stage, better remove from stop stage. I'm afraid it's not a good idea to just remove the intr_disable from dev_st= op. I think dev_stop have the chance to be used independently with dev_unint. I= n this scenario, we still need intr_disable, right? Maybe what we need is some check before we disable the intr:)