From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH] e1000/base: Add missing braces to the
	'if'	statements
Date: Fri, 24 Jun 2016 00:43:40 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348A2A5@shsmsx102.ccr.corp.intel.com>
References: <20160623092552.30932-1-mchandras@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: Markos Chandras <mchandras@suse.de>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 2D5B4C668
 for <dev@dpdk.org>; Fri, 24 Jun 2016 02:43:45 +0200 (CEST)
In-Reply-To: <20160623092552.30932-1-mchandras@suse.de>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Markos,


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Markos Chandras
> Sent: Thursday, June 23, 2016 5:26 PM
> To: dev@dpdk.org
> Cc: Markos Chandras
> Subject: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if'
> statements
>=20
> Add the missing braces to the 'if' statements to fix the misleading ident=
ation.
> This also fixes the following build errors when building with gcc >=3D 6:
>=20
> drivers/net/e1000/base/e1000_phy.c:4156:2:
> error: this 'if' clause does not guard... [-Werror=3Dmisleading-indentati=
on] if
> (locked) ^~
>=20
> drivers/net/e1000/base/e1000_phy.c:4158:3:
> note: ...this statement, but the latter is misleadingly indented as if it=
 is guarded
> by the 'if'
> if (!ready)
> ^~
>=20
> drivers/net/e1000/base/e1000_phy.c: In function 'e1000_write_phy_reg_mphy=
':
> drivers/net/e1000/base/e1000_phy.c:4221:2:
> error: this 'if' clause does not guard... [-Werror=3Dmisleading-indentati=
on] if
> (locked) ^~
>=20
> drivers/net/e1000/base/e1000_phy.c:4223:3:
> note: ...this statement, but the latter is misleadingly indented as if it=
 is guarded
> by the 'if'
> if (!ready)
> ^~
>=20
> Signed-off-by: Markos Chandras <mchandras@suse.de>
Thanks for this patch. But normally the code in the base directory is synce=
d from the kernel driver. So we don't change it if there's no critical issu=
e. It's easy for us to maintain it. Thanks.