From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH] net/e1000: advertise offload capabilities
	for the EM PMD
Date: Mon, 13 Mar 2017 03:15:49 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com>
References: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 8EB2ACFFE
 for <dev@dpdk.org>; Mon, 13 Mar 2017 04:15:54 +0100 (CET)
In-Reply-To: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

> -----Original Message-----
> From: Allain Legacy [mailto:allain.legacy@windriver.com]
> Sent: Friday, March 10, 2017 10:38 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: [PATCH] net/e1000: advertise offload capabilities for the EM PMD
>=20
> The hardware offload capabilities are not being advertised for the EM PMD=
.
> Because of this, applications that only enable these features if the devi=
ce
> advertises them will never do so.
>=20
> Normally this is not an issue since normal packet processing should work =
even if
> hardware offload is not available.  But, in older versions of Virtual Box=
 the e1000
> device emulation (Intel PRO/1000 MT Desktop 82540EM) assumes that it shou=
ld
> enable VLAN stripping even if the driver does not request it.  This means=
 that any
> ingress packets that have a VLAN tag will be stripped.  Since the applica=
tion did
> not request to enable VLAN stripping it is not expecting these packets so=
 they
> are not processed as VLAN packets.
>=20
> Regardless of the Virtual Box issue, the driver should be advertising sup=
ported
> capabilities as is done in other drivers.
>=20
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>