From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lu, Wenzhuo" Subject: Re: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Date: Fri, 21 Apr 2017 06:43:36 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com> References: <1491987746-10155-1-git-send-email-wei.dai@intel.com> <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: "Dai, Wei" , "thomas.monjalon@6wind.com" , "harish.patil@cavium.com" , "rasesh.mody@cavium.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "Zhang, Helin" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Chen, Jing D" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "Richardson, Bruce" , "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" Return-path: In-Reply-To: <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wei, > -----Original Message----- > From: Dai, Wei > Sent: Thursday, April 13, 2017 4:21 PM > To: thomas.monjalon@6wind.com; harish.patil@cavium.com; > rasesh.mody@cavium.com; stephen.hurd@broadcom.com; > ajit.khaparde@broadcom.com; Lu, Wenzhuo; Zhang, Helin; Ananyev, > Konstantin; Wu, Jingjing; Chen, Jing D; adrien.mazarguil@6wind.com; > nelio.laranjeiro@6wind.com; Richardson, Bruce; > yuanhan.liu@linux.intel.com; maxime.coquelin@redhat.com > Cc: dev@dpdk.org; Dai, Wei; stable@dpdk.org > Subject: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr >=20 > some customers find adding mac addr to VF sometimes can fail, but it is s= till > stored in dev->data->mac_addrs[ ]. So this can lead to some errors that > assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. >=20 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Dai > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 7 +++++-- > drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++------ > drivers/net/e1000/base/e1000_api.c | 2 +- > drivers/net/e1000/em_ethdev.c | 6 +++--- > drivers/net/e1000/igb_ethdev.c | 5 +++-- > drivers/net/enic/enic.h | 2 +- > drivers/net/enic/enic_ethdev.c | 4 ++-- > drivers/net/enic/enic_main.c | 6 +++--- > drivers/net/fm10k/fm10k_ethdev.c | 3 ++- > drivers/net/i40e/i40e_ethdev.c | 11 ++++++----- > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++---- > drivers/net/ixgbe/ixgbe_ethdev.c | 27 ++++++++++++++++++--------- > drivers/net/mlx4/mlx4.c | 18 +++++++++++------- > drivers/net/mlx5/mlx5.h | 4 ++-- > drivers/net/mlx5/mlx5_mac.c | 16 ++++++++++------ > drivers/net/qede/qede_ethdev.c | 6 ++++-- > drivers/net/ring/rte_eth_ring.c | 3 ++- > drivers/net/virtio/virtio_ethdev.c | 13 +++++++------ > lib/librte_ether/rte_ethdev.c | 15 +++++++++------ > lib/librte_ether/rte_ethdev.h | 2 +- > 20 files changed, 100 insertions(+), 70 deletions(-) >=20 >=20 > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > b/drivers/net/e1000/base/e1000_api.c > index f7cf83b..dcb53f7 100644 > --- a/drivers/net/e1000/base/e1000_api.c > +++ b/drivers/net/e1000/base/e1000_api.c > @@ -855,7 +855,7 @@ int e1000_rar_set(struct e1000_hw *hw, u8 *addr, > u32 index) > if (hw->mac.ops.rar_set) > return hw->mac.ops.rar_set(hw, addr, index); >=20 > - return E1000_SUCCESS; > + return E1000_ERR_NO_SPACE; > } NACK here. Normally we try to avoid changing base code. And I don't think t= he change is necessary.