From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr
Date: Tue, 2 May 2017 01:21:32 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59E5D7@shsmsx102.ccr.corp.intel.com>
References: <1491987746-10155-1-git-send-email-wei.dai@intel.com>
 <cover.1492071245.git.wei.dai@intel.com>
 <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com>
 <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: "Dai, Wei" <wei.dai@intel.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>, "harish.patil@cavium.com"
 <harish.patil@cavium.com>, "rasesh.mody@cavium.com" <rasesh.mody@cavium.com>,
 "stephen.hurd@broadcom.com" <stephen.hurd@broadcom.com>,
 "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>,
 "Chen, Jing D" <jing.d.chen@intel.com>, "adrien.mazarguil@6wind.com"
 <adrien.mazarguil@6wind.com>, "nelio.laranjeiro@6wind.com"
 <nelio.laranjeiro@6wind.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "yuanhan.liu@linux.intel.com"
 <yuanhan.liu@linux.intel.com>, "maxime.coquelin@redhat.com"
 <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Wei,


> -----Original Message-----
> From: Dai, Wei
> Sent: Saturday, April 29, 2017 2:09 PM
> To: Lu, Wenzhuo; thomas.monjalon@6wind.com; harish.patil@cavium.com;
> rasesh.mody@cavium.com; stephen.hurd@broadcom.com;
> ajit.khaparde@broadcom.com; Zhang, Helin; Ananyev, Konstantin; Wu,
> Jingjing; Chen, Jing D; adrien.mazarguil@6wind.com;
> nelio.laranjeiro@6wind.com; Richardson, Bruce;
> yuanhan.liu@linux.intel.com; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr
>=20
> HI, Wenzhuo
>=20
> > >
> > >  int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int
> > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c
> > > b/drivers/net/e1000/base/e1000_api.c
> > > index f7cf83b..dcb53f7 100644
> > > --- a/drivers/net/e1000/base/e1000_api.c
> > > +++ b/drivers/net/e1000/base/e1000_api.c
> > > @@ -855,7 +855,7 @@ int e1000_rar_set(struct e1000_hw *hw, u8 *addr,
> > > u32 index)
> > >  	if (hw->mac.ops.rar_set)
> > >  		return hw->mac.ops.rar_set(hw, addr, index);
> > >
> > > -	return E1000_SUCCESS;
> > > +	return E1000_ERR_NO_SPACE;
> > >  }
> > NACK here. Normally we try to avoid changing base code. And I don't
> > think the change is necessary.
>=20
> If this code is not changed, the code in ethdev may get wrong return valu=
e
> and assume the failed MAC addr is added.
> Anyway, we can ask the base code to be revised by the associated team.
' hw->mac.ops.rar_set ' cannot be NULL. That's why I think this change is n=
ot necessary.