From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH 1/3] drivers/net: add support for IF-MIB and
 EtherLike-MIB for e1000
Date: Tue, 23 May 2017 05:53:17 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5BBD53@shsmsx102.ccr.corp.intel.com>
References: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com>
 <20170522143202.22424-2-michalx.k.jastrzebski@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F0113CF3E@irsmsx110.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Jain, Deepak K" <deepak.k.jain@intel.com>, "Van Haaren, Harry"
 <harry.van.haaren@intel.com>, "Azarewicz, PiotrX T"
 <piotrx.t.azarewicz@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "Jastrzebski, MichalX K"
 <michalx.k.jastrzebski@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 025692C16
 for <dev@dpdk.org>; Tue, 23 May 2017 07:53:23 +0200 (CEST)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F0113CF3E@irsmsx110.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Michal,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pattan, Reshma
> Sent: Tuesday, May 23, 2017 12:35 AM
> To: Jastrzebski, MichalX K; dev@dpdk.org
> Cc: Jain, Deepak K; Van Haaren, Harry; Azarewicz, PiotrX T
> Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB a=
nd
> EtherLike-MIB for e1000
>=20
> Hi,
>=20
> Can you add the description to the commit message, describing what has
> been done.
>=20
> General doubt I have , I see all IF-MIB and Ether-Like-MIB attributes are
> added as Xstats.
> But most of  IF-MIB attributes are not stats, instead they are informatio=
n
> about the interface/port.
> So I guess such attributes should be displayed using separate method?
> Everything being displayed as xstats might not be correct.
The same question as Reshma. Seems most of the added parameters (if not all=
) are not stats.