From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH v4 3/4] net/softnic: add TM capabilities ops
Date: Mon, 25 Sep 2017 02:33:19 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD155@shsmsx102.ccr.corp.intel.com>
References: <20170811124929.118564-2-jasvinder.singh@intel.com>
 <20170918091015.82824-1-jasvinder.singh@intel.com>
 <20170918091015.82824-4-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 2C5BD23A
 for <dev@dpdk.org>; Mon, 25 Sep 2017 04:34:23 +0200 (CEST)
In-Reply-To: <20170918091015.82824-4-jasvinder.singh@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jasvinder,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Monday, September 18, 2017 5:10 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net
> Subject: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops
>=20
> Implement ethdev TM capability APIs in SoftNIC PMD.
>=20
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  drivers/net/softnic/rte_eth_softnic.c           |  12 +-
>  drivers/net/softnic/rte_eth_softnic_internals.h |  32 ++
>  drivers/net/softnic/rte_eth_softnic_tm.c        | 500
> ++++++++++++++++++++++++
>  3 files changed, 543 insertions(+), 1 deletion(-)
The same concern of the naming as patch 2.The function and structure names =
are too common. Better add the prefix 'softnic_' too.
Except that, the patch looks good to me.