From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [PATCH v3 10/10] app/testpmd: fix on the flight
	VLAN	configuration
Date: Tue, 9 Jan 2018 11:44:44 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70CA09@shsmsx102.ccr.corp.intel.com>
References: <cover.1513082773.git.shahafs@mellanox.com>
 <cover.1514281259.git.shahafs@mellanox.com>
 <cb133a7457f19431477945cdc2747984b35edec2.1514281260.git.shahafs@mellanox.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B70C5D9@shsmsx102.ccr.corp.intel.com>
 <VI1PR05MB3149DDE841BA9FB1F088B05CC3100@VI1PR05MB3149.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Shahaf Shuler <shahafs@mellanox.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 120131B1A7
 for <dev@dpdk.org>; Tue,  9 Jan 2018 12:44:48 +0100 (CET)
In-Reply-To: <VI1PR05MB3149DDE841BA9FB1F088B05CC3100@VI1PR05MB3149.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shahaf,

> -----Original Message-----
> From: Shahaf Shuler [mailto:shahafs@mellanox.com]
> Sent: Tuesday, January 9, 2018 6:04 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight
> VLAN configuration
>=20
> Tuesday, January 9, 2018 10:06 AM, Lu, Wenzhuo:
> > > Subject: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight
> > > VLAN configuration
> > >
> > > On ethdev there is an API to configure VLAN offloads after the port
> > > was started and without reconfiguration of the port or queues.
> > >
> > > In the current design of the application, when the Rx offloads are
> > > changed (through "port config all" CLI command) the port
> > > configuration is overwritten, therefore the configuration made for th=
e
> VLAN is lost.
> > >
> > > This patch is to address the issue by a configuration of each port
> > > Rx offloads separately instead of using the global Rx config.
> > >
> > > Fixes: 6dbb2b336586 ("app/testpmd: convert to new Ethdev Rx offloads
> > > API")
> > This patch is not applied yet. The number 6dbb2b336586 could be
> > meaningless. If the previous patch need to be fixed, may I suggest
> > just merge this one to that? Or this patch fixes some older issues actu=
ally?
>=20
> Well, this was done per Ferruh's request to better split the patches.
>=20
> I can merge it with the Rx one, agreed?
I think this patch fixes the bug in the old code. This bug is not introduce=
d by "app/testpmd: convert to new Ethdev Rx offloads API". You set this fix=
es tag only because the code is changed so much by "app/testpmd: convert to=
 new Ethdev Rx offloads API". It's helpful to create an individual patch. T=
o my opinion, just remove the fixes tag is enough.