From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lu, Wenzhuo" Subject: Re: [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership Date: Wed, 17 Jan 2018 00:46:40 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B711969@shsmsx102.ccr.corp.intel.com> References: <1511870281-15282-1-git-send-email-matan@mellanox.com> <1515318351-4756-1-git-send-email-matan@mellanox.com> <1515318351-4756-7-git-send-email-matan@mellanox.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B7110ED@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Neil Horman , "Richardson, Bruce" , "Ananyev, Konstantin" To: 'Matan Azrad' , Thomas Monjalon , Gaetan Rivet , "Wu, Jingjing" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 94DCC2951 for ; Wed, 17 Jan 2018 01:46:45 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, > -----Original Message----- > From: Matan Azrad [mailto:matan@mellanox.com] > Sent: Tuesday, January 16, 2018 4:16 PM > To: Lu, Wenzhuo ; Thomas Monjalon > ; Gaetan Rivet ; Wu, > Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, > Bruce ; Ananyev, Konstantin > > Subject: RE: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port > ownership >=20 > Hi Lu > From: Lu, Wenzhuo, Tuesday, January 16, 2018 7:54 AM > > Hi Matan, > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matan Azrad > > > Sent: Sunday, January 7, 2018 5:46 PM > > > To: Thomas Monjalon ; Gaetan Rivet > > > ; Wu, Jingjing > > > Cc: dev@dpdk.org; Neil Horman ; Richardson, > > > Bruce ; Ananyev, Konstantin > > > > > > Subject: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port > > > ownership > > > > > > Testpmd should not use ethdev ports which are managed by other DPDK > > > entities. > > > > > > Set Testpmd ownership to each port which is not used by other entity > > > and prevent any usage of ethdev ports which are not owned by Testpmd. > > Sorry I don't follow all the discussion as there's too much. So it may > > be a silly question. >=20 > No problem, I'm here for any question :) >=20 > > Testpmd already has the parameter " --pci-whitelist" to only use the > > assigned devices. >=20 > It is an EAL parameter. No? just say to EAL which devices to create.. >=20 > > When using this parameter, all the devices are owned by the current > > APP. >=20 > No, what's about vdev? vdevs may manage devices(even whitlist PCI devices= ) > by themselves and want to prevent any app to use these devices(see fail- > safe PMD). I'm not an expert of EAL and vdev. Suppose this would be discussed in other= patches. I don't want to bother you again here as testpmd is only used to show the r= esult. So I think if this patch is needed just depends on if other patches are acc= epted :) >=20 > > So I don't know why need to set/check the ownership. > > BTW, in this patch, seem all the change is for ownership checking. I > > don't find the setting code. Do I miss something? >=20 > Yes, see in main function (the first FOREACH). I think you mean this change, @@ -2394,7 +2406,12 @@ uint8_t port_is_bonding_slave(portid_t slave_pid) rte_pdump_init(NULL); #endif =20 - nb_ports =3D (portid_t) rte_eth_dev_count(); + if (rte_eth_dev_owner_new(&my_owner.id)) + rte_panic("Failed to get unique owner identifier\n"); + snprintf(my_owner.name, sizeof(my_owner.name), TESTPMD_OWNER_NAME); + RTE_ETH_FOREACH_DEV_OWNED_BY(port_id, RTE_ETH_DEV_NO_OWNER) + if (rte_eth_dev_owner_set(port_id, &my_owner) =3D=3D 0) + nb_ports++; if (nb_ports =3D=3D 0) RTE_LOG(WARNING, EAL, "No probed ethernet devices\n"); But I thought about some code to assign a specific device to a specific APP= explicitly. This code looks like just occupying the devices with no owner. So, it means= the first APP will occupy all the devices? It makes me confused as I don't= see the benefit or the difference than before. >=20 > Thanks, Matan.