[PATCH] ceph: fix buffer pointer advance in ceph_sync_write

[PATCH] ceph: fix buffer pointer advance in ceph_sync_write

[Henry C Chang]

We should advance the user data pointer by _len_ instead of _written_.
_len_ is the data length written in each iteration while _written_ is the
accumulated data length we have writtent out.

Signed-off-by: Henry C Chang <henry.cy.chang@gmail.com>
---
 fs/ceph/file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index e51558f..4bcbcb6 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -608,7 +608,7 @@ out:
 		pos += len;
 		written += len;
 		left -= len;
-		data += written;
+		data += len;
 		if (left)
 			goto more;
 
-- 
1.7.9.5

Re: [PATCH] ceph: fix buffer pointer advance in ceph_sync_write

[Greg Farnum]

Sage beat me to it and merged this in last night. Thanks much! 
-Greg
Software Engineer #42 @ http://inktank.com | http://ceph.com


On Monday, March 18, 2013 at 6:46 PM, Henry C Chang wrote:

> We should advance the user data pointer by _len_ instead of _written_.
> _len_ is the data length written in each iteration while _written_ is the
> accumulated data length we have writtent out.
> 
> Signed-off-by: Henry C Chang <henry.cy.chang@gmail.com>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index e51558f..4bcbcb6 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -608,7 +608,7 @@ out:
> pos += len;
> written += len;
> left -= len;
> - data += written;
> + data += len;
> if (left)
> goto more;
> 
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html