From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bhushan Bharat-R65777 Subject: RE: [PATCH 3/3] KVM: PPC: booke: Added debug handler Date: Fri, 10 Aug 2012 06:55:08 +0000 Message-ID: <6A3DF150A5B70D4F9B66A25E3F7C888D03DF740B@039-SN2MPN1-022.039d.mgd.msft.net> References: <1343977723-25341-1-git-send-email-Bharat.Bhushan@freescale.com> <1343977723-25341-3-git-send-email-Bharat.Bhushan@freescale.com> <50217E2E.6060607@freescale.com> <6A3DF150A5B70D4F9B66A25E3F7C888D03DF3A06@039-SN2MPN1-022.039d.mgd.msft.net> <1ECD37CE-927F-4E13-B12E-21CF3B701896@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: Wood Scott-B07421 , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" To: Alexander Graf Return-path: In-Reply-To: <1ECD37CE-927F-4E13-B12E-21CF3B701896@suse.de> Content-Language: en-US Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org > -----Original Message----- > From: kvm-ppc-owner@vger.kernel.org [mailto:kvm-ppc-owner@vger.kernel.org] On > Behalf Of Alexander Graf > Sent: Wednesday, August 08, 2012 4:41 PM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org > Subject: Re: [PATCH 3/3] KVM: PPC: booke: Added debug handler > > > On 08.08.2012, at 03:02, Bhushan Bharat-R65777 wrote: > > > > > > >> -----Original Message----- > >> From: Wood Scott-B07421 > >> Sent: Wednesday, August 08, 2012 2:15 AM > >> To: Alexander Graf > >> Cc: Bhushan Bharat-R65777; kvm-ppc@vger.kernel.org; > >> kvm@vger.kernel.org; Bhushan > >> Bharat-R65777 > >> Subject: Re: [PATCH 3/3] KVM: PPC: booke: Added debug handler > >> > >> On 08/07/2012 05:47 AM, Alexander Graf wrote: > >>>> diff --git a/arch/powerpc/kvm/booke_interrupts.S > >>>> b/arch/powerpc/kvm/booke_interrupts.S > >>>> index 3539805..890673c 100644 > >>>> --- a/arch/powerpc/kvm/booke_interrupts.S > >>>> +++ b/arch/powerpc/kvm/booke_interrupts.S > >>>> @@ -73,6 +73,51 @@ _GLOBAL(kvmppc_handler_\ivor_nr) > >>>> bctr > >>>> .endm > >>>> > >>>> +.macro KVM_DBG_HANDLER ivor_nr scratch srr0 > >>> > >>> This is a lot of asm code. Any chance to share a good share of it > >>> with the > >> generic handler? > >> > >> That entire file could use an update to lok more like > >> bookehv_interrupts.S and its use of asm macros. > > > > In booke there is assumption that size of KVM IVORs will not me more than host > IVORs size so that only IVPR is changed. > > > > I tried to give it that shape of bookehv_interrupts.S and found that size of > some IVORs become more than host IVORs. > > We can always jump off to another (more generic?) function and only have a small > stub in the IVOR referenced code. What extra KVM_DBG_HANDLER have from KVM_HANDLER is the handing of debug single step (which is similar to host). So do you want a jump in assembly for handling the debug single step? Or you really think of moving something from the KVM_HANDLER to more generic? Thanks -Bharat