From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLl09-0003TO-CX for qemu-devel@nongnu.org; Tue, 09 Oct 2012 21:22:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLl08-0000ut-8g for qemu-devel@nongnu.org; Tue, 09 Oct 2012 21:22:21 -0400 From: Bhushan Bharat-R65777 Date: Wed, 10 Oct 2012 01:22:16 +0000 Message-ID: <6A3DF150A5B70D4F9B66A25E3F7C888D064B926D@039-SN2MPN1-022.039d.mgd.msft.net> References: <1349806750-17652-1-git-send-email-Bharat.Bhushan@freescale.com> <1349806750-17652-3-git-send-email-Bharat.Bhushan@freescale.com> <1349822276.26044.14@snotra> In-Reply-To: <1349822276.26044.14@snotra> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Adding BAR0 for e500 PCI controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wood Scott-B07421 Cc: "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" , "afaerber@suse.de" , "agraf@suse.de" > -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, October 10, 2012 4:08 AM > To: Bhushan Bharat-R65777 > Cc: qemu-devel@nongnu.org; qemu-ppc@nongnu.org; agraf@suse.de; afaerber@s= use.de; > Bhushan Bharat-R65777 > Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Adding BAR0 for e500 PCI control= ler >=20 > On 10/09/2012 01:19:10 PM, Bharat Bhushan wrote: > > +static int e500_ccsr_initfn(SysBusDevice *dev) { > > + PPCE500CCSRState *pci_ccsr; > > + > > + pci_ccsr =3D CCSR(dev); > > + memory_region_init(&pci_ccsr->ccsr_space, "e500-ccsr", > > + MPC8544_CCSRBAR_SIZE); > > + return 0; > > +} >=20 > Is this object supposed to represent CCSR (which is what the type name se= ems to > imply, along with the existence of a different > PPCE500PCIBridgeState) or PCI BAR0 (which is what pci_ccsr seems to imply= , along > with the fact that it's being added in the PCI patch)? It is ccsr, I will correct this naming. Thanks -Bharat