All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2] docs: mention MyFirstContribution in more places
Date: Mon, 8 Jun 2020 17:25:05 -0400	[thread overview]
Message-ID: <6BD1731B-8D1D-4A07-BE23-70AEB740C455@gmail.com> (raw)
In-Reply-To: <20200608211132.194267-1-emilyshaffer@google.com>

Hi Emily,

> Le 8 juin 2020 à 17:11, Emily Shaffer <emilyshaffer@google.com> a écrit :
> 
> While the MyFirstContribution guide exists and has received some use and
> positive reviews, it is still not as discoverable as it could be. Add a
> reference to it from the GitHub pull request template, where many
> brand-new contributors may look. Also add a reference to it in
> SubmittingPatches, which is the central source of guidance for patch
> contribution.
> 
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> 
> Since v1, only the tiny nit - took Philippe's advice to refer to a
> "step-by-step" tutorial, instead of an "interactive" tutorial.
> 
> Thanks.
> - Emily

Thanks. Looks good. 

Reviewed-by: Philippe Blain <levraiphilippeblain@gmail.com>

  reply	other threads:[~2020-06-08 21:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 23:49 [PATCH] docs: mention MyFirstContribution in more places Emily Shaffer
2020-05-29  1:06 ` Jonathan Nieder
2020-05-29  1:36   ` Philippe Blain
2020-06-08 20:47     ` Emily Shaffer
2020-06-08 21:11 ` [PATCH v2] " Emily Shaffer
2020-06-08 21:25   ` Philippe Blain [this message]
2020-06-08 22:12     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6BD1731B-8D1D-4A07-BE23-70AEB740C455@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.