All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pantelis Antoniou <panto@antoniou-consulting.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: s5p: properly mask SELBASECLK
Date: Wed, 18 Mar 2015 09:52:33 +0200	[thread overview]
Message-ID: <6C22B621-A909-4BE2-8D77-7B88C75F5FB0@antoniou-consulting.com> (raw)
In-Reply-To: <1424728342-5367-1-git-send-email-mreimer@sdgsystems.com>

Hi Matt,

> On Feb 23, 2015, at 23:52 , Matt Reimer <mreimer@sdgsystems.com> wrote:
> 
> Properly mask SELBASECLK by using an actual mask rather than the
> number of bits to shift in order to create the mask.
> 
> Signed-off-by: Matt Reimer <mreimer@sdgsystems.com>
> ---
> drivers/mmc/s5p_sdhci.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
> index 3899372..0eec731 100644
> --- a/drivers/mmc/s5p_sdhci.c
> +++ b/drivers/mmc/s5p_sdhci.c
> @@ -30,7 +30,7 @@ static void s5p_sdhci_set_control_reg(struct sdhci_host *host)
> 	sdhci_writel(host, SDHCI_CTRL4_DRIVE_MASK(0x3), SDHCI_CONTROL4);
> 
> 	val = sdhci_readl(host, SDHCI_CONTROL2);
> -	val &= SDHCI_CTRL2_SELBASECLK_SHIFT;
> +	val &= SDHCI_CTRL2_SELBASECLK_MASK(3);
> 
> 	val |=	SDHCI_CTRL2_ENSTAASYNCCLR |
> 		SDHCI_CTRL2_ENCMDCNFMSK |
> -- 
> 1.7.9.5
> 

Thanks, applied.

? Pantelis

      parent reply	other threads:[~2015-03-18  7:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 18:31 [U-Boot] Possible bug in s5p_sdhci.c Matt Reimer
2015-02-23 17:56 ` Pantelis Antoniou
2015-02-23 21:52   ` [U-Boot] [PATCH] mmc: s5p: properly mask SELBASECLK Matt Reimer
2015-02-25  9:32     ` Jaehoon Chung
2015-03-02 18:31     ` Matt Reimer
2015-03-18  7:52     ` Pantelis Antoniou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6C22B621-A909-4BE2-8D77-7B88C75F5FB0@antoniou-consulting.com \
    --to=panto@antoniou-consulting.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.