From mboxrd@z Thu Jan 1 00:00:00 1970 From: B, Ravi Date: Tue, 2 May 2017 12:48:36 +0000 Subject: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu References: <1493295321-15498-1-git-send-email-ravibabu@ti.com> <1493295321-15498-3-git-send-email-ravibabu@ti.com> <20170427123256.GQ12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B6E7E1@DBDE04.ent.ti.com> <20170427181313.GW12511@bill-the-cat> Message-ID: <6C6B28D4DC342643927BEAFCE8707BF6C0B7498B@DBDE04.ent.ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >Tom >>> >> >>> >> static int dfu_find_alt_num(const char *s) >>> >>> >So do we still need the above, in order to save space? How much are we saving here even, now? Thanks! >>> >>> I observed around 7K reduced. Ignore 7K figure provided, that's wrong calculation. >I don't just mean dropping out CLI, I mean after dropping out CLI but leaving in the reset logic. That's _still_ 7k? >Without this fix, with cli_simple_run_command(), size of MLO with default dra7xx_evm_defconfig is 130K. >With this fix, compile out cli.c, the MLO size is 126K. >Around 4K is space saved. do_reset() used instead of run_command() for dfu_reset(). Regards Ravi