From mboxrd@z Thu Jan 1 00:00:00 1970 From: B, Ravi Date: Tue, 2 May 2017 14:54:50 +0000 Subject: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu In-Reply-To: <20170502145418.GM12511@bill-the-cat> References: <1493295321-15498-1-git-send-email-ravibabu@ti.com> <1493295321-15498-3-git-send-email-ravibabu@ti.com> <20170427123256.GQ12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B6E7E1@DBDE04.ent.ti.com> <20170427181313.GW12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B74922@DBDE04.ent.ti.com> <20170502125747.GK12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B749F3@DBDE04.ent.ti.com> <20170502131930.GL12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B74A97@DBDE04.ent.ti.com> <20170502145418.GM12511@bill-the-cat> Message-ID: <6C6B28D4DC342643927BEAFCE8707BF6C0B74C50@DBDE04.ent.ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >-----Original Message----- >From: Tom Rini [mailto:trini at konsulko.com] >Sent: Tuesday, May 02, 2017 8:24 PM >To: B, Ravi >Cc: u-boot at lists.denx.de >Subject: Re: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu >On Tue, May 02, 2017 at 01:56:45PM +0000, B, Ravi wrote: >> Tom >> >> >>Can you give the exact bytes saved in each case, with your specific compiler? I ask since I'm surprised it's more than a function being dropped by the linker in this case. diff'ing the u-boot-spl.map files would also say what is dropped and I'd be interested in that. >> (And >yes, I'm asking for more details to justify adding a Kconfig option here). >> >>Thanks >> >> >Compiler : arm-linu-gnueabihif-gcc, version: 6.2-2016.11) >> >> >1) default dra7xx_evm_defconfig and use cli_simple_runcommand - MLO >> >size is 129998 >> This is with no patches. >> >> >2) default dra7xx_evm_defconfig and dropping CLI and use do_reset - MLO size is 126130, saving is ~4K (129998-126130 = 3878 bytes). >> This 4K saving is based on this V2 patches series (excludes only CONFIG_DFU_MMC in SPL-DFU). >> >> >3) default dra7xx_evm_defconfig and dropping CLI and dropping do_reset - MLO size is 125298, saving is ~5K (129998-125298 = 4708 bytes). >> (My bad, I changed to V1 initial series in between while taking this >> data) This 5K saving is based on this V1 patches (basically, which >> excludes all CONFIG_DFU_ in SPL-DFU) Dropping do_reset in SPL does not reduce the MLO size. I observe do_reset is always included in spl-uboot.map whether exclude and include. >So in other words, we don't save any space by making DFU-reset be conditionally included? Thanks! Yes, you are correct Tom. Thanks & Regards Ravi