From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756635AbdDRK5Y convert rfc822-to-8bit (ORCPT ); Tue, 18 Apr 2017 06:57:24 -0400 Received: from hermes.aosc.io ([199.195.250.187]:36474 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756366AbdDRK4A (ORCPT ); Tue, 18 Apr 2017 06:56:00 -0400 Date: Tue, 18 Apr 2017 18:55:50 +0800 In-Reply-To: References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-10-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803 To: Chen-Yu Tsai CC: Lee Jones , Rob Herring , Maxime Ripard , Liam Girdwood , Mark Brown , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi From: Icenowy Zheng Message-ID: <6D57E4F4-DD87-400F-A21B-85778434AADC@aosc.io> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2017年4月18日 GMT+08:00 下午6:38:09, Chen-Yu Tsai 写到: >On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng wrote: >> As axp20x-regulator now supports AXP803, add a cell for it. >> >> Signed-off-by: Icenowy Zheng >> --- >> Changes in v3: >> - Make the new cell one-liner. >> >> drivers/mfd/axp20x.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 1dc6235778eb..431b7f118606 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = { >> .name = "axp20x-pek", >> .num_resources = >ARRAY_SIZE(axp803_pek_resources), >> .resources = axp803_pek_resources, >> - } >> + }, >> + { .name = "axp20x-regulator" } > >It's best to have a trailing comma, so we don't have to change the line >again when we add more cells, like you just did with the previous line. Should I also add it in previous mfd patch? (and remove the addition of the comma in this patch) > >Otherwise, > >Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803 Date: Tue, 18 Apr 2017 18:55:50 +0800 Message-ID: <6D57E4F4-DD87-400F-A21B-85778434AADC@aosc.io> References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-10-icenowy@aosc.io> Reply-To: icenowy-h8G6r0blFSE@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Lee Jones , Rob Herring , Maxime Ripard , Liam Girdwood , Mark Brown , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org =E4=BA=8E 2017=E5=B9=B44=E6=9C=8818=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=886:= 38:09, Chen-Yu Tsai =E5=86=99=E5=88=B0: >On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng wrote: >> As axp20x-regulator now supports AXP803, add a cell for it. >> >> Signed-off-by: Icenowy Zheng >> --- >> Changes in v3: >> - Make the new cell one-liner. >> >> drivers/mfd/axp20x.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 1dc6235778eb..431b7f118606 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] =3D { >> .name =3D "axp20x-pek", >> .num_resources =3D >ARRAY_SIZE(axp803_pek_resources), >> .resources =3D axp803_pek_resources, >> - } >> + }, >> + { .name =3D "axp20x-regulator" } > >It's best to have a trailing comma, so we don't have to change the line >again when we add more cells, like you just did with the previous line. Should I also add it in previous mfd patch? (and remove the addition of the= comma in this patch) > >Otherwise, > >Acked-by: Chen-Yu Tsai --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.io (Icenowy Zheng) Date: Tue, 18 Apr 2017 18:55:50 +0800 Subject: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803 In-Reply-To: References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-10-icenowy@aosc.io> Message-ID: <6D57E4F4-DD87-400F-A21B-85778434AADC@aosc.io> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2017?4?18? GMT+08:00 ??6:38:09, Chen-Yu Tsai ??: >On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng wrote: >> As axp20x-regulator now supports AXP803, add a cell for it. >> >> Signed-off-by: Icenowy Zheng >> --- >> Changes in v3: >> - Make the new cell one-liner. >> >> drivers/mfd/axp20x.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 1dc6235778eb..431b7f118606 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = { >> .name = "axp20x-pek", >> .num_resources = >ARRAY_SIZE(axp803_pek_resources), >> .resources = axp803_pek_resources, >> - } >> + }, >> + { .name = "axp20x-regulator" } > >It's best to have a trailing comma, so we don't have to change the line >again when we add more cells, like you just did with the previous line. Should I also add it in previous mfd patch? (and remove the addition of the comma in this patch) > >Otherwise, > >Acked-by: Chen-Yu Tsai