From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kovacevic, Marko" Subject: Re: [PATCH] doc: update softnic doc for flow and qos API support Date: Thu, 18 Oct 2018 12:24:37 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020382D1@IRSMSX104.ger.corp.intel.com> References: <1539859449-8248-1-git-send-email-reshma.pattan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Singh, Jasvinder" To: "Pattan, Reshma" , "dev@dpdk.org" , "Mcnamara, John" Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id F1AFA5F14 for ; Thu, 18 Oct 2018 14:24:47 +0200 (CEST) In-Reply-To: <1539859449-8248-1-git-send-email-reshma.pattan@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Update document with flow and qos api support in softnic PMD. >=20 > Signed-off-by: Jasvinder Singh > Signed-off-by: Reshma Pattan > --- > doc/guides/nics/softnic.rst | 119 > ++++++++++++++++++++++++++++++++++++ > 1 file changed, 119 insertions(+) id 1) > + > +QoS API Support: > +---------------- > + > +SoftNIC PMD implements ethdev traffic management APIs ``rte_tm.h`` that > +allow building and committing traffic manager hierarchy, configuring > +hierarchy nodes of the Quality of Service (QoS) scheduler supported by > +DPDK librte_sched library. Furthermore, APIs for run-time update to the > +traffic manager hierarchy are supported by PMD. > + > +SoftNIC PMD also implements ethdev traffic metering and policing APIs > +``rte_mtr.h`` that enables metering and marking of the packets with the > +appropriate color (green, yellow or red), according to the traffic > +metering algorithm. For the meter output color, policer actions can be > +configured which include keep the same packet color (essentially a > +no-op action), override the color the packet or drop the packet. The one thing here I notice is the sentence=20 " policer actions can be configured which include keep the same packet colo= r " "which include keep" sounds weird,=20 Maybe one of these " policer actions can be configured which include the same packet color " " policer actions can be configured which keep the same packet color " > +.. Note: > + > +The SoftNIC does not support the meter object shared by several flows, > +thus only supports creating meter object private to the flow. Once > +meter object is successfully created, it can be linked to the specific > +flow by specifying the ``meter`` flow action in the flow rule. Your note doesn't come out as a note because you didn't indent your text. Note: > + > +The flow must have one terminating actions i.e. ``JMP or RSS or QUEUE or > DROP``. > +For the count and drop actions the underlying PMD doesn't support the > +functionality yet. So it is not recommended for use. Same here. Reviewed-by: Marko Kovacevic