All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"Varghese, Vipin" <vipin.varghese@intel.com>
Subject: Re: [PATCH v1] mk: fix external build failure
Date: Mon, 5 Feb 2018 10:53:31 +0000	[thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66342959@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <189741475.qmuB92lqII@xps>

> 05/02/2018 11:22, Marko Kovacevic:
> > Updated the make build to fix external build issues
> 
> Please explain what is the issue.
> 
> > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > Cc: stable@dpdk.org
> 
> No need to Cc stable when fixing a bug which is not in a major release.

Olivier reported an issue this morning, that my commit was breaking 
the build of one of our external module:

make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory                                                                                                                      
make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'.  Stop.                                                                                                            

The reason is that entries in $(MAKEFILE_LIST) can be absolute.

Marko.

  reply	other threads:[~2018-02-05 10:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 10:22 [PATCH v1] mk: fix external build failure Marko Kovacevic
2018-02-05 10:37 ` Thomas Monjalon
2018-02-05 10:53   ` Kovacevic, Marko [this message]
2018-02-05 14:07     ` Thomas Monjalon
2018-02-05 22:38     ` Thomas Monjalon
2018-02-05 15:45 ` [PATCH v2] " Marko Kovacevic
2018-02-05 22:39   ` Thomas Monjalon
2018-02-05 18:26 ` [dpdk-stable] [PATCH v1] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC05C7C5F25994B81B3F2F214251F66342959@IRSMSX104.ger.corp.intel.com \
    --to=marko.kovacevic@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.