From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D50C04AAF for ; Tue, 21 May 2019 19:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDC5A217D7 for ; Tue, 21 May 2019 19:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727525AbfEUT7y convert rfc822-to-8bit (ORCPT ); Tue, 21 May 2019 15:59:54 -0400 Received: from voltaic.bi-co.net ([134.119.3.22]:57996 "EHLO voltaic.bi-co.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727222AbfEUT7x (ORCPT ); Tue, 21 May 2019 15:59:53 -0400 Received: from lass-mb.fritz.box (aftr-95-222-30-100.unity-media.net [95.222.30.100]) by voltaic.bi-co.net (Postfix) with ESMTPSA id 253CB20BA8; Tue, 21 May 2019 21:59:51 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [dm-devel] fstrim discarding too many or wrong blocks on Linux 5.1, leading to data loss From: =?utf-8?Q?Michael_La=C3=9F?= In-Reply-To: <20190521190023.GA68070@glet> Date: Tue, 21 May 2019 21:59:50 +0200 Cc: dm-devel@redhat.com, Chris Murphy , Qu Wenruo , Btrfs BTRFS , Mike Snitzer Content-Transfer-Encoding: 8BIT Message-Id: <6E217E83-E4FB-489F-BF23-1EA71E20C939@bi-co.net> References: <297da4cbe20235080205719805b08810@bi-co.net> <8C31D41C-9608-4A65-B543-8ABCC0B907A0@bi-co.net> <158a3491-e4d2-d905-7f58-11a15bddcd70@gmx.com> <3142764D-5944-4004-BC57-C89C89AC9ED9@bi-co.net> <20190521190023.GA68070@glet> To: Andrea Gelmini X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org > Am 21.05.2019 um 21:00 schrieb Andrea Gelmini : > > On Tue, May 21, 2019 at 06:46:20PM +0200, Michael Laß wrote: >>> I finished bisecting. Here’s the responsible commit: >>> >>> commit 61697a6abd24acba941359c6268a94f4afe4a53d >>> Author: Mike Snitzer >>> Date: Fri Jan 18 14:19:26 2019 -0500 >>> >>> dm: eliminate 'split_discard_bios' flag from DM target interface >>> >>> There is no need to have DM core split discards on behalf of a DM target >>> now that blk_queue_split() handles splitting discards based on the >>> queue_limits. A DM target just needs to set max_discard_sectors, >>> discard_granularity, etc, in queue_limits. >>> >>> Signed-off-by: Mike Snitzer >> >> Reverting that commit solves the issue for me on Linux 5.1.3. Would that be an option until the root cause has been identified? I’d rather not let more people run into this issue. > > Thanks a lot Michael, for your time/work. > > This kind of bisecting are very boring and time consuming. I just sent a patch to dm-devel which fixes the issue for me. Maybe you can test that in your environment? Cheers, Michael PS: Sorry if the patch was sent multiple times. I had some issues with git send-email. > I CC: also the patch author. > > Thanks again, > Andrea